From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdKZQTD (ORCPT ); Sun, 26 Nov 2017 11:19:03 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:44304 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbdKZQTC (ORCPT ); Sun, 26 Nov 2017 11:19:02 -0500 X-Google-Smtp-Source: AGs4zMZZnIU56v54kvumA1uwEj1I6aNdCSXRbf5B4Zy5dPGLyReUyoM/XUN8EkNfOWxkb/L6K/0PRA== From: Gimcuan Hui To: Johan Hovold Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] USB: serial: Correct return value on read Date: Sun, 26 Nov 2017 16:18:51 +0000 Message-Id: <20171126161851.25650-1-gimcuan@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's meaningless to return buf[0] on read. Because the caller of this interface checks the return value negative or not. Instead, we should return the result variable. Signed-off-by: Gimcuan Hui --- drivers/usb/serial/ark3116.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c index 3c544782f60b..bfdbc7164e7b 100644 --- a/drivers/usb/serial/ark3116.c +++ b/drivers/usb/serial/ark3116.c @@ -101,11 +101,9 @@ static int ark3116_read_reg(struct usb_serial *serial, reg, result); if (result >= 0) result = -EIO; - - return result; } - return buf[0]; + return result; } static inline int calc_divisor(int bps) -- 2.11.0