From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751368AbdK0Ihb (ORCPT ); Mon, 27 Nov 2017 03:37:31 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38526 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdK0Ih3 (ORCPT ); Mon, 27 Nov 2017 03:37:29 -0500 X-Google-Smtp-Source: AGs4zMaEuJHbRg9oPE5O3+hymxIA2GRhWlpW16oPGwfNzpZoKa2CtLqLO/pugN0C4RgitjM4YrHBLA== Date: Mon, 27 Nov 2017 16:37:15 +0800 From: Peng Fan To: Marek Szyprowski Cc: Peng Fan , hch@lst.de, robin.murphy@arm.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, frowand.list@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC 2/2] drivers: dma-mapping: parse per device reserved mem at probe time Message-ID: <20171127083713.clh6oz5sgere4usq@linux-u7w5.ap.freescale.net> References: <20171126131346.12532-1-peng.fan@nxp.com> <20171126131346.12532-2-peng.fan@nxp.com> <875c3a8c-a857-823e-0243-487d1dd9bee7@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875c3a8c-a857-823e-0243-487d1dd9bee7@samsung.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On Mon, Nov 27, 2017 at 09:31:00AM +0100, Marek Szyprowski wrote: >Hi > >On 2017-11-26 14:13, Peng Fan wrote: >> Invoke of_reserved_mem_device_init at dma_configure, then >> there is no need to call of_reserved_mem_device_init in device >> specific probe function. >> >> Signed-off-by: Peng Fan > >This has been already tried long time ago, without success: >http://patches.linaro.org/patch/33558/ Thanks for the info. I should first search mail list before sending out patches. Thanks, Peng. > >> --- >> drivers/base/dma-mapping.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c >> index e584eddef0a7..55dca06a7b55 100644 >> --- a/drivers/base/dma-mapping.c >> +++ b/drivers/base/dma-mapping.c >> @@ -12,6 +12,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> @@ -351,7 +352,9 @@ int dma_configure(struct device *dev) >> } >> if (dma_dev->of_node) { >> - ret = of_dma_configure(dev, dma_dev->of_node); >> + ret = of_reserved_mem_device_init(dev); >> + if (ret) >> + ret = of_dma_configure(dev, dma_dev->of_node); >> } else if (has_acpi_companion(dma_dev)) { >> attr = acpi_get_dma_attr(to_acpi_device_node(dma_dev->fwnode)); >> if (attr != DEV_DMA_NOT_SUPPORTED) >> @@ -367,5 +370,6 @@ int dma_configure(struct device *dev) >> void dma_deconfigure(struct device *dev) >> { >> of_dma_deconfigure(dev); >> + of_reserved_mem_device_release(dev); >> acpi_dma_deconfigure(dev); >> } > >Best regards >-- >Marek Szyprowski, PhD >Samsung R&D Institute Poland > --