From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, X86 ML <x86@kernel.org>,
Borislav Petkov <bpetkov@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86/orc: Don't bail on stack overflow
Date: Mon, 27 Nov 2017 10:38:42 +0100 [thread overview]
Message-ID: <20171127093842.xppvp53ozr2av4lg@gmail.com> (raw)
In-Reply-To: <20171126024031.uxi4numpbjm5rlbr@treble>
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Sat, Nov 25, 2017 at 04:16:23PM -0800, Andy Lutomirski wrote:
> > Can you send me whatever config and exact commit hash generated this?
> > I can try to figure out why it failed.
>
> Sorry, I've been traveling. I just got some time to take a look at
> this. I think there are at least two unwinder issues here:
>
> - It doesn't deal gracefully with the case where the stack overflows and
> the stack pointer itself isn't on a valid stack but the
> to-be-dereferenced data *is*.
>
> - The oops dump code doesn't know how to print partial pt_regs, for the
> case where if we get an interrupt/exception in *early* entry code
> before the full pt_regs have been saved.
>
> (Andy, I'm not quite sure about your patch, and whether it's still
> needed after these patches. I'll need to look at it later when I have
> more time.)
>
> I attempted to fix both of the issues with the below patch. Thomas or
> Ingo, can you test to see if this gets rid of the question marks?
>
> I can split it up into proper patches next week. I'm assuming this
> isn't holding up the KAISER merge?
It's not holding up the Kaiser merge, but good debuggability of weird crashes is a
really good thing, so I constructed a changelog and picked up this patch as a
single commit, and added your Signed-off-by, if that's OK with you.
Will only push it out if it passes testing.
Thanks,
Ingo
next prev parent reply other threads:[~2017-11-27 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 17:28 Andy Lutomirski
2017-11-25 18:26 ` Andy Lutomirski
2017-11-25 23:13 ` Thomas Gleixner
2017-11-26 0:16 ` Andy Lutomirski
2017-11-26 2:40 ` Josh Poimboeuf
2017-11-26 4:25 ` Andy Lutomirski
2017-11-26 4:41 ` Josh Poimboeuf
2017-11-26 4:48 ` Josh Poimboeuf
2017-11-26 9:27 ` Thomas Gleixner
2017-11-27 9:38 ` Ingo Molnar [this message]
2017-11-27 9:49 ` Ingo Molnar
2017-11-27 12:45 ` Josh Poimboeuf
2017-11-27 13:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127093842.xppvp53ozr2av4lg@gmail.com \
--to=mingo@kernel.org \
--cc=bpetkov@suse.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@intel.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome