From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbdK0KWC (ORCPT ); Mon, 27 Nov 2017 05:22:02 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35158 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbdK0KWA (ORCPT ); Mon, 27 Nov 2017 05:22:00 -0500 X-Google-Smtp-Source: AGs4zMYaZ04RHxjjVJqNmj9hMHsgpS/5uqWS93nfuWUwPjOQn5ZSL1bokh0KOEB3mHd55MX+e6SXCg== Date: Mon, 27 Nov 2017 11:21:57 +0100 From: Daniel Vetter To: Nick Desaulniers Cc: mika.kahola@intel.com, paulo.r.zanoni@intel.com, mka@chromium.org, daniel@ffwll.ch, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/i915: Avoid enum conversion warning Message-ID: <20171127102157.7qzjckiym2xjftn7@phenom.ffwll.local> Mail-Followup-To: Nick Desaulniers , mika.kahola@intel.com, paulo.r.zanoni@intel.com, mka@chromium.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20171123075946.x2unvonwbaojjxsr@phenom.ffwll.local> <20171127034914.2291-1-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127034914.2291-1-nick.desaulniers@gmail.com> X-Operating-System: Linux phenom 4.13.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 26, 2017 at 07:49:14PM -0800, Nick Desaulniers wrote: > Fixes the following enum conversion warning: > > drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion > from enumeration type 'enum port' to different enumeration type 'enum > intel_dpll_id' [-Werror,-Wenum-conversion] > enum intel_dpll_id pll_id = port; > ~~~~~~ ^~~~ > > Suggested-by: Daniel Vetter > Signed-off-by: Nick Desaulniers This doesn't apply on latest drm-intel.git code anymore, we removed this. Thanks anyway. -Daniel > --- > drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index 933c18fd4258..3c346c8cbf78 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -1477,8 +1477,8 @@ static void bxt_ddi_clock_get(struct intel_encoder *encoder, > struct intel_crtc_state *pipe_config) > { > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - enum port port = intel_ddi_get_encoder_port(encoder); > - enum intel_dpll_id pll_id = port; > + enum intel_dpll_id pll_id = > + (enum intel_dpll_id)intel_ddi_get_encoder_port(encoder); > > pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id); > > -- > 2.14.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch