From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbdK0UdX (ORCPT ); Mon, 27 Nov 2017 15:33:23 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:39551 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbdK0UdV (ORCPT ); Mon, 27 Nov 2017 15:33:21 -0500 X-Google-Smtp-Source: AGs4zMZlfvoFagQN9e3Mjf5XSCOzU4TN9g/FVvFqi8jMIpNfhmXBkWPDKGqmE/feFSPS1nniNqA5CQ== Date: Mon, 27 Nov 2017 12:33:19 -0800 From: Jakub Kicinski To: Greg Kroah-Hartman , Nicolai Stange Cc: linux-kernel@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset Message-ID: <20171127123319.3c1d19fd@cakuba.netronome.com> In-Reply-To: <20171127185134.13405-1-jakub.kicinski@netronome.com> References: <20171127185134.13405-1-jakub.kicinski@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Nov 2017 10:51:34 -0800, Jakub Kicinski wrote: > Recent commit moved the implementation of debugfs_real_fops() > out of the header file. The declaration, however, is only > provided if CONFIG_DEBUG_FS is set. Add an empty static inline > definition for when CONFIG_DEBUG_FS is unset. > > Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata") > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Argh, should've been a static inline.