From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
Yueyao Zhu <yueyao.zhu@gmail.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
linux-usb@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, support.opensource@diasemi.com
Subject: Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class
Date: Mon, 27 Nov 2017 15:38:52 +0200 [thread overview]
Message-ID: <20171127133852.GB2403@kuha.fi.intel.com> (raw)
In-Reply-To: <3f1b813d-a9a9-756e-718c-5b2aa2b72906@redhat.com>
On Sat, Nov 25, 2017 at 03:03:02PM +0100, Hans de Goede wrote:
> > Is it OK to everybody that the type of the psy is changed like that?
> > Hans?!
> >
> > We do have drivers that already change the type, for example
> > drivers/power/supply/isp1704_charger.c, but what does the user space
> > expect? The ABI for the power supply class was never documented I
> > guess.
>
> The main userspace consumer of the power_supply sysfs class is upower,
> upower knows about 3 types: "Mains", "Battery" and "USB", anything
> else it gives a type of UP_DEVICE_KIND_UNKNOWN. So POWER_SUPPLY_TYPE_USB_TYPE_C
> vs POWER_SUPPLY_TYPE_USB_PD_PPS does matter to it.
OK.
Thanks Hans,
--
heikki
next prev parent reply other threads:[~2017-11-27 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 11:44 [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 2/7] typec: tcpm: Add ADO header for Alert message handling Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 3/7] typec: tcpm: Add SDB header for Status " Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 4/7] typec: tcpm: Add core support for sink side PPS Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 5/7] power: supply: Add type for USB PD PPS chargers Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class Adam Thomson
2017-11-24 12:19 ` Heikki Krogerus
2017-11-24 14:05 ` Adam Thomson
2017-11-27 14:11 ` Heikki Krogerus
2017-11-27 16:54 ` Adam Thomson
2017-11-28 11:45 ` Heikki Krogerus
2017-11-25 14:03 ` Hans de Goede
2017-11-27 13:38 ` Heikki Krogerus [this message]
2017-11-27 13:43 ` Adam Thomson
2017-11-14 11:44 ` [RFC PATCH v2 7/7] typec: tcpm: Add support for sink PPS related messages Adam Thomson
2017-11-21 13:35 ` [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS Heikki Krogerus
2017-11-21 13:51 ` Adam Thomson
2017-11-21 14:18 ` Heikki Krogerus
2017-11-21 14:21 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127133852.GB2403@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rmfrfs@gmail.com \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=yueyao.zhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®