From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521AbdK0N7Q (ORCPT ); Mon, 27 Nov 2017 08:59:16 -0500 Received: from mail.skyhub.de ([5.9.137.197]:34224 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbdK0N7O (ORCPT ); Mon, 27 Nov 2017 08:59:14 -0500 Date: Mon, 27 Nov 2017 14:59:05 +0100 From: Borislav Petkov To: Thomas Gleixner Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , "H . Peter Anvin" , Peter Zijlstra , Linus Torvalds Subject: Re: [PATCH 00/24] x86/mm: Add KAISER support Message-ID: <20171127135905.d74secm2cgsg4wbq@pd.tnic> References: <20171127104923.14378-1-mingo@kernel.org> <20171127135138.k4v4b3szwe3a2mjb@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 02:57:17PM +0100, Thomas Gleixner wrote: > On Mon, 27 Nov 2017, Borislav Petkov wrote: > > On Mon, Nov 27, 2017 at 11:48:59AM +0100, Ingo Molnar wrote: > > > Sending this out for another round of review. > > > > > > These are the main KAISER patches, on top of the preparatory series I just sent. > > > This includes KAISER support plus enhancements on top, all the latest code. > > > > > > ( All review feedback so far is incorporated - if anything is missing please > > > let me know. ) > > > > Something's missing: > > > > arch/x86/boot/compressed/pagetable.o: In function `kernel_ident_mapping_init': > > pagetable.c:(.text+0x3cc): undefined reference to `kaiser_enabled' > > pagetable.c:(.text+0x400): undefined reference to `__supported_pte_mask' > > pagetable.c:(.text+0x473): undefined reference to `system_state' > > make[2]: *** [arch/x86/boot/compressed/vmlinux] Error 1 > > make[1]: *** [arch/x86/boot/compressed/vmlinux] Error 2 > > make: *** [bzImage] Error 2 > > make: *** Waiting for unfinished jobs.... > > > > I suspect it is that core patch but need to stare at it more. .config > > attached. > > That's the core patch plus the run time enablement I did. Right, and I think the fix is as simple as this because we don't care about kaiser in the bootstrap kernel: --- diff --git a/arch/x86/boot/compressed/pagetable.c b/arch/x86/boot/compressed/pagetable.c index d5364ca2e3f9..63eaa71ad9f1 100644 --- a/arch/x86/boot/compressed/pagetable.c +++ b/arch/x86/boot/compressed/pagetable.c @@ -22,6 +22,7 @@ * the SME support to avoid any compile and link errors. */ #undef CONFIG_AMD_MEM_ENCRYPT +#undef CONFIG_KAISER #include "misc.h" -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.