From: Jiri Pirko <jiri@resnulli.us>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
y2038@lists.linaro.org, Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Mike Maloney <maloney@google.com>,
Eric Dumazet <edumazet@google.com>,
Kees Cook <keescook@chromium.org>,
"Rosen, Rami" <rami.rosen@intel.com>,
Andrey Konovalov <andreyknvl@google.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Sowmini Varadhan <sowmini.varadhan@oracle.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps
Date: Mon, 27 Nov 2017 17:59:45 +0100 [thread overview]
Message-ID: <20171127165945.GC1971@nanopsycho.orion> (raw)
In-Reply-To: <20171127162001.4055813-2-arnd@arndb.de>
Mon, Nov 27, 2017 at 05:19:25PM CET, arnd@arndb.de wrote:
>I tried to figure out what it would take to do a version 4 mmap packet
>socket interface to completely avoid the y2106 overflow problem. This is
>what I came up with, reusing most of the v3 code, except for the parts
>where we access the timestamps.
>
>For kselftest, I'm adding support for testing v4 in addition to v1-v3,
>but the test currently does not look at the timestamps, so it won't
>check that the timestamp format actually works as intended, only that
>I didn't break the parts that worked in the v3 selftest.
>
>Overall, this is more of a mess than I expected, so it's probably not
>worth doing a v4 format just for the timestamp, but the patch can serve
>as a reference for anyone that needs a new format for other reasons and
>fixes this along with the other changes.
>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
[...]
>@@ -250,7 +269,8 @@ struct tpacket_block_desc {
> enum tpacket_versions {
> TPACKET_V1,
> TPACKET_V2,
>- TPACKET_V3
>+ TPACKET_V3,
>+ TPACKET_V4,
I wonder with how many versions are we going to eventually end up with :O
next prev parent reply other threads:[~2017-11-27 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 16:19 [PATCH 1/2] [net-next] packet: clarify timestamp overflow Arnd Bergmann
2017-11-27 16:19 ` [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps Arnd Bergmann
2017-11-27 16:59 ` Jiri Pirko [this message]
2017-11-27 20:35 ` Willem de Bruijn
2017-11-27 20:51 ` Arnd Bergmann
2017-11-28 7:04 ` Björn Töpel
2017-11-28 8:46 ` Arnd Bergmann
2017-11-28 13:14 ` [PATCH] [RFC v2] " Arnd Bergmann
2017-11-28 14:24 ` Willem de Bruijn
2017-11-28 14:45 ` Arnd Bergmann
2017-11-28 15:05 ` David Miller
2017-11-28 20:02 ` Arnd Bergmann
2017-11-28 20:08 ` David Miller
2017-11-28 20:31 ` Arnd Bergmann
2017-11-28 20:32 ` [PATCH] [RFC v3] " Arnd Bergmann
2017-11-28 22:28 ` Willem de Bruijn
2017-11-29 12:31 ` Arnd Bergmann
2017-11-29 16:51 ` Willem de Bruijn
2017-11-29 20:06 ` Arnd Bergmann
2017-11-30 1:39 ` Willem de Bruijn
2017-11-30 1:54 ` Willem de Bruijn
2017-11-29 13:45 ` [PATCH] [RFC v4] " Arnd Bergmann
2017-11-28 14:08 ` [PATCH 2/2] [RFC] " Willem de Bruijn
2017-11-28 14:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127165945.GC1971@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maloney@google.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=shuah@kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=willemb@google.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®