From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbdK0UVZ (ORCPT ); Mon, 27 Nov 2017 15:21:25 -0500 Received: from mga06.intel.com ([134.134.136.31]:46952 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712AbdK0UVX (ORCPT ); Mon, 27 Nov 2017 15:21:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,465,1505804400"; d="scan'208";a="180814669" Date: Mon, 27 Nov 2017 12:21:21 -0800 From: Andi Kleen To: Michal Hocko Cc: Mikael Pettersson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] mm: disable `vm.max_map_count' sysctl limit Message-ID: <20171127202121.GB3070@tassilo.jf.intel.com> References: <23066.59196.909026.689706@gargle.gargle.HOWL> <20171127101232.ykriowhatecnvjvg@dhcp22.suse.cz> <87vahv8whv.fsf@linux.intel.com> <20171127183218.33zm666jw3uqkxdq@dhcp22.suse.cz> <20171127195732.3hkfx57d3ytyccvp@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127195732.3hkfx57d3ytyccvp@dhcp22.suse.cz> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 08:57:32PM +0100, Michal Hocko wrote: > On Mon 27-11-17 19:32:18, Michal Hocko wrote: > > On Mon 27-11-17 09:25:16, Andi Kleen wrote: > [...] > > > The reason the limit was there originally because it allows a DoS > > > attack against the kernel by filling all unswappable memory up with VMAs. > > > > We can reduce the effect by accounting vmas to memory cgroups. > > As it turned out we already do. > vm_area_cachep = KMEM_CACHE(vm_area_struct, SLAB_PANIC|SLAB_ACCOUNT); That only helps if you have memory cgroups enabled. It would be a regression to break the accounting on all the systems that don't. -Andi