mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Li Zefan" <lizefan@huawei.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-doc@vger.kernel.org, "Mike Galbraith" <efault@gmx.de>,
	"Christian Brauner" <christian.brauner@canonical.com>,
	"Stéphane Graber" <stgraber@ubuntu.com>,
	"Serge Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy
Date: Mon, 27 Nov 2017 13:04:11 -0800	[thread overview]
Message-ID: <20171127210411.GS983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1507324230-22996-1-git-send-email-longman@redhat.com>

Hello, Waiman.

Sorry about the long delay.

On Fri, Oct 06, 2017 at 05:10:30PM -0400, Waiman Long wrote:
> +Cpuset Interface Files
> +~~~~~~~~~~~~~~~~~~~~~~
> +
> +  cpuset.cpus
> +	A read-write multiple values file which exists on non-root
> +	cgroups.
> +
> +	It lists the CPUs allowed to be used by tasks within this
> +	cgroup.  The CPU numbers are comma-separated numbers or
> +	ranges.  For example:
> +
> +	  # cat cpuset.cpus
> +	  0-4,6,8-10
> +
> +	An empty value indicates that the cgroup is using the same
> +	setting as the nearest cgroup ancestor with a non-empty
> +	"cpuset.cpus" or all the available CPUs if none is found.
> +
> +	The value of "cpuset.cpus" stays constant until the next update
> +	and won't be affected by any CPU hotplug events.
> +
> +  cpuset.effective_cpus

Can we do cpuset.ecpus in the fashion of euid, egid..?

> +  cpuset.effective_mems

Ditto.

> +  cpuset.flags
> +	A read-write multiple values file which exists on non-root
> +	cgroups.
> +
> +	It lists the flags that are set (with a '+' prefix) and those
> +	that are not set (with a '-' prefix).	The currently supported
> +	flag is:
> +
> +	  mem_migrate
> +		When it is not set, an allocated memory page will
> +		stay in whatever node it was allocated independent
> +		of changes in "cpuset.mems".
> +
> +		When it is set, tasks with memory pages not in
> +		"cpuset.mems" will have those pages migrated over to
> +		memory nodes specified in "cpuset.mems".  Any changes
> +		to "cpuset.mems" will cause pages in nodes that are
> +		no longer valid to be migrated over to the newly
> +		valid nodes.

Let's start just with [e]cpus and [e]mems.  The flags interface looks
fine but the implementations of these features are really bad and
cgroup2 doesn't migrate resources for other controllers either anyway.

Thanks.

-- 
tejun

  parent reply	other threads:[~2017-11-27 21:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 21:10 Waiman Long
2017-10-25 15:50 ` Waiman Long
2017-10-26 14:39   ` Tejun Heo
2017-10-26 18:12     ` Waiman Long
2017-10-26 20:59       ` Christian Brauner
2017-11-14 17:49       ` Waiman Long
2017-11-27 21:04 ` Tejun Heo [this message]
2017-11-27 21:19   ` Waiman Long
2017-11-27 21:42     ` Tejun Heo
2017-11-27 21:47       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127210411.GS983427@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=christian.brauner@canonical.com \
    --cc=corbet@lwn.net \
    --cc=efault@gmx.de \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=longman@redhat.com \
    --cc=serge@hallyn.com \
    --cc=stgraber@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome