From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752142AbdK0VLU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 16:11:20 -0500
Received: from mail-oi0-f67.google.com ([209.85.218.67]:36704 "EHLO
        mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751921AbdK0VLR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 16:11:17 -0500
X-Google-Smtp-Source: AGs4zMZtg7paJyCoPIx3xszR7Q+CDBBwz8w143ediDatPgKij9eBYD02yBfN1hvNGJ4+X7lZGZzOUw==
Date: Mon, 27 Nov 2017 13:11:14 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Tejun Heo <tj@kernel.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
        Christoph Lameter <cl@linux.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>, linux-cris-kernel@axis.com
Subject: Re: mm/percpu.c: use smarter memory allocation for struct
 pcpu_alloc_info (crisv32 hang)
Message-ID: <20171127211114.GA23806@roeck-us.net>
References: <nycvar.YSQ.7.76.1710031731130.5407@knanqh.ubzr>
 <20171118182542.GA23928@roeck-us.net>
 <20171127194105.GM983427@devbig577.frc2.facebook.com>
 <nycvar.YSQ.7.76.1711271515540.5925@knanqh.ubzr>
 <20171127203335.GQ983427@devbig577.frc2.facebook.com>
 <nycvar.YSQ.7.76.1711271534590.5925@knanqh.ubzr>
 <20171127205421.GR983427@devbig577.frc2.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171127205421.GR983427@devbig577.frc2.facebook.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 27, 2017 at 12:54:21PM -0800, Tejun Heo wrote:
> Hello, Nicolas.
> 
> On Mon, Nov 27, 2017 at 03:51:04PM -0500, Nicolas Pitre wrote:
> > Subject: percpu: hack to let the CRIS architecture to boot until they clean up
> > 
> > Commit 438a506180 ("percpu: don't forget to free the temporary struct 
> > pcpu_alloc_info") uncovered a problem on the CRIS architecture where
> > the bootmem allocator is initialized with virtual addresses. Given it 
> > has:
> > 
> >     #define __va(x) ((void *)((unsigned long)(x) | 0x80000000))
> > 
> > then things just work out because the end result is the same whether you
> > give this a physical or a virtual address.
> > 
> > Untill you call memblock_free_early(__pa(address)) that is, because
> > values from __pa() don't match with the virtual addresses stuffed in the
> > bootmem allocator anymore.
> > 
> > Avoid freeing the temporary pcpu_alloc_info memory on that architecture
> > until they fix things up to let the kernel boot like it did before.
> > 
> > Signed-off-by: Nicolas Pitre <nico@linaro.org>
> 
> This totally works for me.  Replaced the revert with this one.
> 
Same here.

Thanks,
Guenter

> Thanks!
> 
> -- 
> tejun