From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbdK1PbG (ORCPT ); Tue, 28 Nov 2017 10:31:06 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753241AbdK1PbC (ORCPT ); Tue, 28 Nov 2017 10:31:02 -0500 Date: Tue, 28 Nov 2017 10:31:00 -0500 (EST) Message-Id: <20171128.103100.87779904958337018.davem@davemloft.net> To: antoine.tenart@free-electrons.com Cc: rmk@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com, gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: marvell10g: fix the PHY id mask From: David Miller In-Reply-To: <20171128132630.26619-1-antoine.tenart@free-electrons.com> References: <20171128132630.26619-1-antoine.tenart@free-electrons.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Nov 2017 07:31:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Tue, 28 Nov 2017 14:26:30 +0100 > The Marvell 10G PHY driver supports different hardware revisions, which > have their bits 3..0 differing. To get the correct revision number these > bits should be ignored. This patch fixes this by using the already > defined MARVELL_PHY_ID_MASK (0xfffffff0) instead of the custom > 0xffffffff mask. > > Fixes: 20b2af32ff3f ("net: phy: add Marvell Alaska X 88X3310 10Gigabit PHY support") > Suggested-by: Yan Markman > Signed-off-by: Antoine Tenart Applied.