From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753753AbdK1A0G (ORCPT ); Mon, 27 Nov 2017 19:26:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:6481 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753199AbdK1AXa (ORCPT ); Mon, 27 Nov 2017 19:23:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,466,1505804400"; d="scan'208";a="12682716" From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, mhiramat@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 05/12] perf, tools, probe: Print location for resolved variables Date: Mon, 27 Nov 2017 16:23:14 -0800 Message-Id: <20171128002321.2878-6-andi@firstfloor.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171128002321.2878-1-andi@firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Print the location, e.g. the register, for resolved variables with perf probe -V. This is useful for debugging, and manually making sense of disassembly. I also have some scripts which can make use of this information. Before: % perf probe -x ./tsrc/tstruct -V main+20 Available variables at main+20 @ struct str* xp After: % perf probe -x ./tsrc/tstruct -V main+20 Available variables at main+20 @ struct str* xp %ax Signed-off-by: Andi Kleen --- tools/perf/util/probe-finder.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index 0149428d453e..699f29d8a28e 100644 --- a/tools/perf/util/probe-finder.c +++ b/tools/perf/util/probe-finder.c @@ -1369,6 +1369,7 @@ static int collect_variables_cb(Dwarf_Die *die_mem, void *data) if (tag == DW_TAG_formal_parameter || tag == DW_TAG_variable) { struct probe_trace_arg ta; + struct probe_trace_arg_ref *ref; memset(&ta, 0, sizeof(struct probe_trace_arg)); ret = convert_variable_location(die_mem, af->pf.addr, @@ -1401,6 +1402,10 @@ static int collect_variables_cb(Dwarf_Die *die_mem, void *data) die_mem, &buf); } + strbuf_addf(&buf, "\t%s", ta.value); + for (ref = ta.ref; ref; ref = ref->next) + strbuf_addf(&buf, " off %ld", ref->offset); + pr_debug("Add new var: %s\n", buf.buf); if (ret2 == 0) { struct str_node *sn; -- 2.13.6