From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdK1G7p (ORCPT ); Tue, 28 Nov 2017 01:59:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40687 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdK1G7o (ORCPT ); Tue, 28 Nov 2017 01:59:44 -0500 X-ME-Sender: Date: Tue, 28 Nov 2017 07:59:49 +0100 From: "greg@kroah.com" To: Hartley Sweeten Cc: Ian Abbott , Alex Frappier Lachapelle , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue Message-ID: <20171128065949.GB6489@kroah.com> References: <20171126015025.11575-1-Alex.FrappierLachapelle@gmail.com> <434bc019-0204-40a2-7575-14aeb1f7cca5@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 05:51:56PM +0000, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory pointed to by 'lrange' and modify it, so 'const' is not appropriate here. > > Ian, > > Wonder if it's worth putting a comment about this in the code. This has come up a > couple times. It's a nice test to see who actually builds the code before they send a patch in :)