From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbdK1K0j (ORCPT ); Tue, 28 Nov 2017 05:26:39 -0500 Received: from mga14.intel.com ([192.55.52.115]:37649 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdK1K0f (ORCPT ); Tue, 28 Nov 2017 05:26:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,467,1505804400"; d="scan'208";a="6774752" Date: Tue, 28 Nov 2017 12:22:10 +0200 From: Mika Westerberg To: Arvind Yadav Cc: rjw@rjwysocki.net, lenb@kernel.org, andy@infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 2/2] ACPI / PMIC: Constify platform_device_id Message-ID: <20171128102210.GY22431@lahna.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 03:31:51PM +0530, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav You may want to change the title to mention the PMIC driver in question like: "ACPI / PMIC / bxtwc: ..." or so. The patch itself is fine, Acked-by: Mika Westerberg