From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nicolai Stange <nicstange@gmail.com>,
linux-kernel@vger.kernel.org, oss-drivers@netronome.com,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset
Date: Tue, 28 Nov 2017 10:23:03 -0800 [thread overview]
Message-ID: <20171128102303.72b4d0a3@cakuba.netronome.com> (raw)
In-Reply-To: <20171128142300.GA14578@kroah.com>
On Tue, 28 Nov 2017 15:23:00 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 12:35:44PM -0800, Jakub Kicinski wrote:
> > Recent commit moved the implementation of debugfs_real_fops()
> > out of the header file. The declaration, however, is only
> > provided if CONFIG_DEBUG_FS is set. Add an empty static inline
> > definition for when CONFIG_DEBUG_FS is unset.
> >
> > Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata")
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> > ---
> > include/linux/debugfs.h | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> Arnd sent me a better patch for this last week that I'll queue up now.
Arnd's patch assumes all call sites can be eliminated, i.e. all of the
users are static functions assigned to static fops and compiler is
clever enough. It does solve my immediate problem but let's wait and
see if that bites us on the rear later :)
prev parent reply other threads:[~2017-11-28 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 20:35 Jakub Kicinski
2017-11-28 11:47 ` [oss-drivers] " Simon Horman
2017-11-28 14:23 ` Greg Kroah-Hartman
2017-11-28 18:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128102303.72b4d0a3@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicstange@gmail.com \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®