From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934033AbdK1K6s (ORCPT ); Tue, 28 Nov 2017 05:58:48 -0500 Received: from mail.skyhub.de ([5.9.137.197]:52950 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933636AbdK1KvX (ORCPT ); Tue, 28 Nov 2017 05:51:23 -0500 Date: Tue, 28 Nov 2017 11:51:10 +0100 From: Borislav Petkov To: Colin King Cc: "Rafael J . Wysocki" , Len Brown , Tony Luck , Tyler Baicar , Will Deacon , linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / APEI: remove redundant variables len and node_len Message-ID: <20171128105110.hrfe6nh7hzmo5p4f@pd.tnic> References: <20171015212454.16012-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171015212454.16012-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 15, 2017 at 10:24:54PM +0100, Colin King wrote: > From: Colin Ian King > > Variables len and node_len are redundant and can be removed. Cleans > up clang warning: node_len = GHES_ESTATUS_NODE_LEN(len); > > Signed-off-by: Colin Ian King > --- > drivers/acpi/apei/ghes.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 3c3a37b8503b..f2e1049232c0 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -923,7 +923,6 @@ static void ghes_print_queued_estatus(void) > struct ghes_estatus_node *estatus_node; > struct acpi_hest_generic *generic; > struct acpi_hest_generic_status *estatus; > - u32 len, node_len; > > llnode = llist_del_all(&ghes_estatus_llist); > /* > @@ -935,8 +934,6 @@ static void ghes_print_queued_estatus(void) > estatus_node = llist_entry(llnode, struct ghes_estatus_node, > llnode); > estatus = GHES_ESTATUS_FROM_NODE(estatus_node); > - len = cper_estatus_len(estatus); > - node_len = GHES_ESTATUS_NODE_LEN(len); > generic = estatus_node->generic; > ghes_print_estatus(NULL, generic, estatus); > llnode = llnode->next; > -- Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.