From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932301AbdK1LrX (ORCPT ); Tue, 28 Nov 2017 06:47:23 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:38493 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbdK1LrU (ORCPT ); Tue, 28 Nov 2017 06:47:20 -0500 X-Google-Smtp-Source: AGs4zMbidwQpufkxknQzisHPHNyIoeyKT4JAH57eoSkfnUGxvQafYlGL2DJ5HosOufdvxlK79F78LA== Date: Tue, 28 Nov 2017 12:47:17 +0100 From: Simon Horman To: Jakub Kicinski Cc: Greg Kroah-Hartman , Nicolai Stange , linux-kernel@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [oss-drivers] [PATCH v2] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset Message-ID: <20171128114716.hi7y7iajadyc3xpg@netronome.com> References: <20171127203544.7708-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127203544.7708-1-jakub.kicinski@netronome.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 12:35:44PM -0800, Jakub Kicinski wrote: > Recent commit moved the implementation of debugfs_real_fops() > out of the header file. The declaration, however, is only > provided if CONFIG_DEBUG_FS is set. Add an empty static inline > definition for when CONFIG_DEBUG_FS is unset. > > Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata") > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman