From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752598AbdK1NMM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 08:12:12 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:48160 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752280AbdK1NMK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 08:12:10 -0500
Date: Tue, 28 Nov 2017 14:09:28 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Chase Metzger <chasemetzger15@gmail.com>
Cc: Marcus Wolf <linux@Wolf-Entwicklungen.de>,
        Joseph Wright <rjosephwright@gmail.com>,
        Elia Geretto <elia.f.geretto@gmail.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        Harsha Sharma <harshasharmaiitr@gmail.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Srishti Sharma <srishtishar@gmail.com>,
        Derek Robson <robsonde@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited
 coding style issues
Message-ID: <20171128130928.GB31525@kroah.com>
References: <cover.1510790802.git.chasemetzger15@gmail.com>
 <51516f05b5632f381a3495f9c0da86421fa1a265.1510790802.git.chasemetzger15@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51516f05b5632f381a3495f9c0da86421fa1a265.1510790802.git.chasemetzger15@gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 15, 2017 at 04:35:51PM -0800, Chase Metzger wrote:
> Remove unnecessary spaces before and after parenthesis' to comply
> with the kernel coding style.
> 
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 3c5d8a05e976..ad89504655af 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -342,7 +342,7 @@ pi433_receive(void *data)
>  		return retval;
>  
>  	/* now check RSSI, if low wait for getting high (RSSI interrupt) */
> -	while ( !rf69_get_flag(dev->spi, rssiExceededThreshold) ) {
> +	while (!rf69_get_flag(dev->spi, rssiExceededThreshold)) {
>  		/* allow tx to interrupt us while waiting for high RSSI */
>  		dev->interrupt_rx_allowed = true;
>  		wake_up_interruptible(&dev->tx_wait_queue);
> @@ -413,7 +413,7 @@ pi433_receive(void *data)
>  
>  	/* get payload */
>  	while (dev->rx_position < bytes_total) {
> -		if ( !rf69_get_flag(dev->spi, payloadReady) ) {
> +		if (!rf69_get_flag(dev->spi, payloadReady)) {
>  			retval = wait_event_interruptible(dev->fifo_wait_queue,
>  							  dev->free_in_fifo < FIFO_SIZE);
>  			if (retval) /* wait was interrupted */
> @@ -473,9 +473,9 @@ pi433_tx_thread(void *data)
>  		/* wait for fifo to be populated or for request to terminate*/
>  		dev_dbg(device->dev, "thread: going to wait for new messages");
>  		wait_event_interruptible(device->tx_wait_queue,
> -					 ( !kfifo_is_empty(&device->tx_fifo) ||
> -					    kthread_should_stop() ));
> -		if ( kthread_should_stop() )
> +					 (!kfifo_is_empty(&device->tx_fifo) ||
> +					    kthread_should_stop()));

Indent this properly too if you are touching it.

thanks,

greg k-h