From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbdK1NNa (ORCPT ); Tue, 28 Nov 2017 08:13:30 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48210 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdK1NN2 (ORCPT ); Tue, 28 Nov 2017 08:13:28 -0500 Date: Tue, 28 Nov 2017 14:13:31 +0100 From: Greg Kroah-Hartman To: Jeremy Lacomis Cc: Sudip Mukherjee , Teddy Wang , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c Message-ID: <20171128131331.GA12924@kroah.com> References: <1511649387.20482.5.camel@perches.com> <20171125224812.23914-1-j.lacomis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171125224812.23914-1-j.lacomis@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote: > This is a patch to sm750_accel.c that fixes 80-character line length > warnings found by checkpatch.pl. It also fixes some grammatical errors > in comments and moves parameter-specific comments from inline to before > the function. > > Signed-off-by: Jeremy Lacomis > --- > Changes in v2: > - Change function comments to the kernel-doc format > > drivers/staging/sm750fb/sm750_accel.c | 189 ++++++++++++++++++---------------- > 1 file changed, 103 insertions(+), 86 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 1035e91e7cd3..42cd920111bf 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +/* SPDX-License-Identifier: GPL-2.0 */ Why did you change this line? That is not correct. Only ever do one "logical" thing per patch. If you have to say "also" in a changelog text, that's a huge hint you are doing something wrong. thanks, greg k-h