From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbdK1N6r (ORCPT ); Tue, 28 Nov 2017 08:58:47 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:44747 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbdK1N6p (ORCPT ); Tue, 28 Nov 2017 08:58:45 -0500 X-Google-Smtp-Source: AGs4zMaVgJxcck/MGjcJyKNK0hlZqAA7aY9lFfSaMDDz0psD8pB66jvxZ+M8diylEd3cNkpBdSZA1w== Date: Tue, 28 Nov 2017 08:58:41 -0500 From: Jeremy Lacomis To: Greg Kroah-Hartman Cc: Sudip Mukherjee , Teddy Wang , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c Message-ID: <20171128135841.GA561@gs17931.sp.cs.cmu.edu> References: <1511649387.20482.5.camel@perches.com> <20171125224812.23914-1-j.lacomis@gmail.com> <20171128131331.GA12924@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128131331.GA12924@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 02:13:31PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote: > > This is a patch to sm750_accel.c that fixes 80-character line length > > warnings found by checkpatch.pl. It also fixes some grammatical errors > > in comments and moves parameter-specific comments from inline to before > > the function. > > > > Signed-off-by: Jeremy Lacomis > > --- > > Changes in v2: > > - Change function comments to the kernel-doc format > > > > drivers/staging/sm750fb/sm750_accel.c | 189 ++++++++++++++++++---------------- > > 1 file changed, 103 insertions(+), 86 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > > index 1035e91e7cd3..42cd920111bf 100644 > > --- a/drivers/staging/sm750fb/sm750_accel.c > > +++ b/drivers/staging/sm750fb/sm750_accel.c > > @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > +/* SPDX-License-Identifier: GPL-2.0 */ > > Why did you change this line? That is not correct. Sorry about this Greg, I wasn't familiar with the format of the license identifier line, and it seemed inconsistent with the rest of the comments at the time. > Only ever do one "logical" thing per patch. If you have to say "also" > in a changelog text, that's a huge hint you are doing something wrong. I'll keep this in mind. I think my natural inclination is to be afraid that the patches I'm sending in are _too_ trivial and breaking up these things into several different patches would create more work for the maintainers. Thanks, - Jeremy