From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdK1OXC (ORCPT ); Tue, 28 Nov 2017 09:23:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58500 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbdK1OW4 (ORCPT ); Tue, 28 Nov 2017 09:22:56 -0500 Date: Tue, 28 Nov 2017 15:23:00 +0100 From: Greg Kroah-Hartman To: Jakub Kicinski Cc: Nicolai Stange , linux-kernel@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH v2] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset Message-ID: <20171128142300.GA14578@kroah.com> References: <20171127203544.7708-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127203544.7708-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 12:35:44PM -0800, Jakub Kicinski wrote: > Recent commit moved the implementation of debugfs_real_fops() > out of the header file. The declaration, however, is only > provided if CONFIG_DEBUG_FS is set. Add an empty static inline > definition for when CONFIG_DEBUG_FS is unset. > > Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata") > Signed-off-by: Jakub Kicinski > --- > include/linux/debugfs.h | 5 +++++ > 1 file changed, 5 insertions(+) Arnd sent me a better patch for this last week that I'll queue up now. thanks, greg k-h