From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078AbdK1Px4 (ORCPT ); Tue, 28 Nov 2017 10:53:56 -0500 Received: from foss.arm.com ([217.140.101.70]:55982 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbdK1Pxy (ORCPT ); Tue, 28 Nov 2017 10:53:54 -0500 Date: Tue, 28 Nov 2017 15:53:52 +0000 From: Liviu Dudau To: Vasyl Gomonovych Cc: arnd@arndb.de, gregkh@linuxfoundation.org, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO() Message-ID: <20171128155352.GS1119@e110455-lin.cambridge.arm.com> References: <1511882443-5851-1-git-send-email-gomonovych@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1511882443-5851-1-git-send-email-gomonovych@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 04:20:43PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych Acked-by: Liviu Dudau > --- > drivers/misc/vexpress-syscfg.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c > index 2cde80c7bb93..9eea30f54fd6 100644 > --- a/drivers/misc/vexpress-syscfg.c > +++ b/drivers/misc/vexpress-syscfg.c > @@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev) > /* Must use dev.parent (MFD), as that's where DT phandle points at... */ > bridge = vexpress_config_bridge_register(pdev->dev.parent, > &vexpress_syscfg_bridge_ops, syscfg); > - if (IS_ERR(bridge)) > - return PTR_ERR(bridge); > > - return 0; > + return PTR_ERR_OR_ZERO(bridge); > } > > static const struct platform_device_id vexpress_syscfg_id_table[] = { > -- > 1.9.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯