From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752150AbdK2BIv (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 20:08:51 -0500
Received: from mx4.wp.pl ([212.77.101.11]:59437 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751350AbdK2BIt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 20:08:49 -0500
Date: Tue, 28 Nov 2017 17:08:40 -0800
From: Jakub Kicinski <kubakici@wp.pl>
To: Matthew Wilcox <willy@infradead.org>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
        Chris Mi <chrism@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Eric Biggers <ebiggers@google.com>,
        Lai Jiangshan <laijs@cn.fujitsu.com>, Tejun Heo <tj@kernel.org>,
        Rehas Sachdeva <aquannie@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32
Message-ID: <20171128170817.1c23d420@cakuba.netronome.com>
In-Reply-To: <20171128213312.28983-12-willy@infradead.org>
References: <20171128213312.28983-1-willy@infradead.org>
        <20171128213312.28983-12-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-WP-MailID: ba2f05ec45723dcef34372bd16d18271
X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski
X-WP-SPAM: NO 0000000 [QVN8]                               
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						INT_MAX, GFP_KERNEL);
> +	} else if (!oldprog) {
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						handle, GFP_KERNEL);

nit: in many places you seem to not align the second line with opening
parenthesis.  Is that intentional?

FWIW there may be a small merge conflict with net on cls_bpf in patch
5, some of the code has been removed.