From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbdK1Vc6 (ORCPT ); Tue, 28 Nov 2017 16:32:58 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:44950 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496AbdK1Vcz (ORCPT ); Tue, 28 Nov 2017 16:32:55 -0500 Date: Tue, 28 Nov 2017 22:32:53 +0100 From: Maxime Ripard To: Stefan Mavrodiev Cc: Rob Herring , Mark Rutland , Russell King , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/1] ARM: dts: sunxi: Update dts for A20-OLinuXino boards Message-ID: <20171128213252.2bysq3kzubio7cxw@flea.home> References: <1511784231-6485-1-git-send-email-stefan@olimex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l4yinkne7y5ramij" Content-Disposition: inline In-Reply-To: <1511784231-6485-1-git-send-email-stefan@olimex.com> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l4yinkne7y5ramij Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stefan, On Mon, Nov 27, 2017 at 02:03:51PM +0200, Stefan Mavrodiev wrote: > There will be option with 16MB flash for the following boards: >=20 > * A20-OLinuXino-MICRO Rev.K > * A20-OLinuXino-LIME Rev.J > * A20-OLinuXino-LIME2 Rev.J > * A20-SOM-EVB Rev.E >=20 > The used flash chip is Winbond W25Q128FV, which is connected to > SPI0 port. Since this is optional feature, spi0 node is dissabled > by default. Also this option is incompatible with NAND flash, so > they shouldn't be enabled at the same time. >=20 > Signed-off-by: Stefan Mavrodiev > --- > arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 14 ++++++++++++++ > arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 14 ++++++++++++++ > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 14 ++++++++++++++ > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 14 ++++++++++++++ > 4 files changed, 56 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/bo= ot/dts/sun7i-a20-olimex-som-evb.dts > index 64c8ef9..98b7697 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts > @@ -291,6 +291,20 @@ > status =3D "okay"; > }; > =20 > +&spi0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi0_pins_b>,<&spi0_cs0_pins_b>; > + status =3D "disabled"; > + > + flash@0 { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + compatible =3D "winbond,w25q128","jedec,spi-nor"; > + reg =3D <0>; > + spi-max-frequency =3D <40000000>; > + }; > +}; > + So those kind of variations are usually best handled using overlays. This as become quite convenient using the FIT image rework that Pantelis did here: https://lists.denx.de/pipermail/u-boot/2017-June/296879.html and got merged since 2017.11. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --l4yinkne7y5ramij Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlod1gEACgkQ0rTAlCFN r3QEQg/9EzHiHydVHE8djnejgdBuQ3XnLvEejg7tVyleSLDJprvTEbirTaEQ5cO3 eCmtIimZz6goCGTykx3X8hyP0l86Tq0suem0ApGTdy+5rCTV0kJraaxPDmlbEbGq 1gnyooHOm5485lPJvvAM/6DhtbMcks1et6stg2Z2uYZvPM+eHQDg3SIM2+QbrNyC 897lZCHQgdJe+DYBaZHjsfnSoCjIKd1hrqxUHug4RlJVpl36F3dVL6IwS35kZofw +TjtUtEc0cG6GDXptyg7hxerwtKmXH9DAMwHdBwYak5UphkuiLP7BIyIGp8pfTYc TOVxwvtRhOQg19+/pkpSFG+k3hetgpmuuyrzFrPU//hBgbsDXFYU5MUOiIaO+JXQ t/s82hqnaqnsZXmhujaA1XzapD8rbOdwXFz+yFvfR3a0WnLbcZWNEG5pQgyr0kUS yXgmkVPD6N/as4ci4DS7B8Bsr123JHOevdeUNn1igBhKOhXFCtHUHToyuoCygcV8 zszVxMcCg+d8n2GuJTC3KSHX5ZEEKXGl0stnGuk4TiC60R4rj33ejgtyTJHPBF5i uU8/yM6fHSPFJaAddqtdAAntX4PccB8ExAZsOSJXVZaFrFjEJ09rYXFTwYJ8zfuK YqekSyUl3Xk03v2/tSjpEK8K+Lp2GrEI0G+qx0ueM2lUA6zW+08= =G67H -----END PGP SIGNATURE----- --l4yinkne7y5ramij--