From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbdK1XIq (ORCPT ); Tue, 28 Nov 2017 18:08:46 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:37824 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbdK1XIo (ORCPT ); Tue, 28 Nov 2017 18:08:44 -0500 X-Google-Smtp-Source: AGs4zMZEgiVrZIC2l7BPBHa28X5W9cnPd4rWpKKHqBMemABz/Ppq+/dGsLP7/mNzUYRD2tKiCmA5vg== Date: Tue, 28 Nov 2017 16:08:34 -0700 From: Jason Gunthorpe To: Geert Uytterhoeven Cc: Tatyana Nikolova , Doug Ledford , Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH/RFC] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo() Message-ID: <20171128230834.GH21325@ziepe.ca> References: <1510827964-11100-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1510827964-11100-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 11:26:04AM +0100, Geert Uytterhoeven wrote: > With gcc-4.1.2: > > drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: > drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function > > Indeed, if nl_client is not found in any of the scanned has buckets, ret > will be used uninitialized. > > Preinitialize ret to zero to fix this. Did we come to a conclusion if we should apply this to the RMDA tree? The patch was marked RFC.. Thanks, Jason > Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service") > Signed-off-by: Geert Uytterhoeven > RFC as I have no idea if this can ever happen, and if yes, what's the > correct behavior to handle it: > - return 0, > - return an error code, > - don't send anything, > - anything else? > drivers/infiniband/core/iwpm_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c > index 3c4faadb8cddd7fd..eb000b540495acd1 100644 > +++ b/drivers/infiniband/core/iwpm_util.c > @@ -644,7 +644,7 @@ int iwpm_send_mapinfo(u8 nl_client, int iwpm_pid) > int i = 0, nlmsg_bytes = 0; > unsigned long flags; > const char *err_str = ""; > - int ret; > + int ret = 0; > > skb = dev_alloc_skb(NLMSG_GOODSIZE); > if (!skb) {