From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbdK2OoO (ORCPT ); Wed, 29 Nov 2017 09:44:14 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395AbdK2OoM (ORCPT ); Wed, 29 Nov 2017 09:44:12 -0500 Date: Wed, 29 Nov 2017 09:44:10 -0500 (EST) Message-Id: <20171129.094410.1537008794654450709.davem@davemloft.net> To: geert+renesas@glider.be Cc: michal.simek@xilinx.com, arnd@arndb.de, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit From: David Miller In-Reply-To: <1511949669-30379-1-git-send-email-geert+renesas@glider.be> References: <1511949669-30379-1-git-send-email-geert+renesas@glider.be> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Nov 2017 06:44:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven Date: Wed, 29 Nov 2017 11:01:09 +0100 > On 64-bit (e.g. powerpc64/allmodconfig): > > drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done': > drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > dev_kfree_skb_irq((struct sk_buff *)cur_p->app4); > ^ > > cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer. > > Note that several other fields in struct cdmac_bd are also too small to > hold physical addresses on 64-bit platforms. > > Signed-off-by: Geert Uytterhoeven Yeah, I can't see much value in implementing a hash table converting between 32-bit cookies and 64-bit points just for this if it'll never be actually used. Applied, thanks Geert.