From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbdK2Qfz (ORCPT ); Wed, 29 Nov 2017 11:35:55 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdK2Qfy (ORCPT ); Wed, 29 Nov 2017 11:35:54 -0500 Date: Wed, 29 Nov 2017 11:35:49 -0500 (EST) Message-Id: <20171129.113549.1990396476364963247.davem@davemloft.net> To: willy@infradead.org Cc: kubakici@wp.pl, mawilcox@microsoft.com, chrism@mellanox.com, jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, daniel@iogearbox.net, ebiggers@google.com, laijs@cn.fujitsu.com, tj@kernel.org, aquannie@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32 From: David Miller In-Reply-To: <20171129162916.GA18402@bombadil.infradead.org> References: <20171128213312.28983-12-willy@infradead.org> <20171128170817.1c23d420@cakuba.netronome.com> <20171129162916.GA18402@bombadil.infradead.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Nov 2017 08:35:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox Date: Wed, 29 Nov 2017 08:29:16 -0800 > On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote: >> On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote: >> > + ret = idr_alloc_u32(&head->handle_idr, prog, &handle, >> > + INT_MAX, GFP_KERNEL); >> > + } else if (!oldprog) { >> > + ret = idr_alloc_u32(&head->handle_idr, prog, &handle, >> > + handle, GFP_KERNEL); >> >> nit: in many places you seem to not align the second line with opening >> parenthesis. Is that intentional? > > It's more that I don't care. I press 'enter', which indents the arguments > by a certain amount, then press the 'tab' key until it looks aesthetically > pleasing. > >> FWIW there may be a small merge conflict with net on cls_bpf in patch >> 5, some of the code has been removed. > > Thanks. Dave, do you want to take the IDR patches through your tree to > save conflict resolution? Sure, after you fix the indentation problems Jakub pointed out please resubmit them separately to netdev.