From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdK2Sib (ORCPT ); Wed, 29 Nov 2017 13:38:31 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:33890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdK2Si3 (ORCPT ); Wed, 29 Nov 2017 13:38:29 -0500 Date: Wed, 29 Nov 2017 13:38:25 -0500 (EST) Message-Id: <20171129.133825.1224896993681699024.davem@davemloft.net> To: andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, software@gaisler.com Subject: Re: [PATCH 1/2] sparc32,leon: Build with -mcpu=leon3 for SPARC_LEON From: David Miller In-Reply-To: <1510668223-18484-2-git-send-email-andreas@gaisler.com> References: <1510668223-18484-1-git-send-email-andreas@gaisler.com> <1510668223-18484-2-git-send-email-andreas@gaisler.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Nov 2017 10:38:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andreas Larsson Date: Tue, 14 Nov 2017 15:03:42 +0100 > Apart from using LEON3 instruction timing it allows for usage of the > CASA instruction. > > Signed-off-by: Andreas Larsson Up until this point the LEON kconfig option is largely passive. All of the sparc_cpu_type logic drives what parts of the kernel are used based upon the run-time detected cpu type. But with this change, it completely breaks the 32-bit sparc kernel on any non-Leon processor. I wish you would reconsider this approach, and instead do hardcoded assembler instruction opcodes to use "casa" in assembler, and run time detect CAS support in the 32-bit cpu. Thank you.