From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932536AbdK2MQP convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 07:16:15 -0500
Received: from mail.kernel.org ([198.145.29.99]:41344 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932478AbdK2MQO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 07:16:14 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 491C22170E
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Wed, 29 Nov 2017 07:16:11 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Xie XiuQi <xiexiuqi@huawei.com>
Cc: <mingo@redhat.com>, <davem@davemloft.net>, <brouer@redhat.com>,
        <daniel@iogearbox.net>, <ast@kernel.org>,
        <kstewart@linuxfoundation.org>, <gregkh@linuxfoundation.org>,
        <john.fastabend@gmail.com>, <linux-kernel@vger.kernel.org>,
        <huangdaode@hisilicon.com>, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH] trace/xdp: fix compile warning: =?UTF-8?B?4oCYc3Ry?=
 =?UTF-8?B?dWN0IGJwZl9tYXDigJk=?= declared inside parameter list
Message-ID: <20171129071611.1dcabe5c@gandalf.local.home>
In-Reply-To: <1511944501-160820-1-git-send-email-xiexiuqi@huawei.com>
References: <1511944501-160820-1-git-send-email-xiexiuqi@huawei.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 29 Nov 2017 16:35:01 +0800
Xie XiuQi <xiexiuqi@huawei.com> wrote:

> We meet this compile warning, which caused by missing bpf.h in xdp.h.
> 
> In file included from ./include/trace/events/xdp.h:10:0,
>                  from ./include/linux/bpf_trace.h:6,
>                  from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29:
> ./include/trace/events/xdp.h:93:17: warning: ‘struct bpf_map’ declared inside parameter list will not be visible outside of this definition or declaration
>     const struct bpf_map *map, u32 map_index),
>
> Reported-by: Huang Daode <huangdaode@hisilicon.com>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
> ---
>  include/trace/events/xdp.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index 4cd0f05..8989a92 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -8,6 +8,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/filter.h>
>  #include <linux/tracepoint.h>
> +#include <linux/bpf.h>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

>  
>  #define __XDP_ACT_MAP(FN)	\
>  	FN(ABORTED)		\