From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: herbert@gondor.apana.org.au, alexandre.torgue@st.com,
arei.gonglei@huawei.com, davem@davemloft.net,
jasowang@redhat.com, mcoquelin.stm32@gmail.com, mst@redhat.com,
fabien.dessenne@st.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: [PATCH RFC 0/4] crypto: engine - Permit to enqueue all async requests
Date: Wed, 29 Nov 2017 09:41:17 +0100 [thread overview]
Message-ID: <20171129084121.9385-1-clabbe.montjoie@gmail.com> (raw)
Hello
The current crypto_engine support only ahash and ablkcipher.
My first patch which try to add skcipher was Nacked, it will add too many functions
and adding other algs(aead, asymetric_key) will make the situation worst.
This patchset remove all algs specific stuff and now only process generic crypto_async_request.
The requests handler function pointer are now moved out of struct engine and
are now stored directly in a crypto_engine_reqctx.
The original proposal of Herbert [1] cannot be done completly since the crypto_engine
could only dequeue crypto_async_request and it is impossible to access any request_ctx
without knowing the underlying request type.
So I do something near that was requested: adding crypto_engine_reqctx in TFM context.
Note that the current implementation expect that crypto_engine_reqctx
is the first member of the context.
The first patch convert the crypto engine with the new way,
while the following patchs convert the 3 existing users of crypto_engine.
Note that this split break bisection, so probably the final commit will be all merged.
The 3 latest patch were compile tested only, but the first is tested successfully
with my new sun8i-ce driver.
Regards
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html
Corentin Labbe (4):
crypto: engine - Permit to enqueue all async requests
crypto: omap: convert to new crypto engine API
crypto: virtio: convert to new crypto engine API
crypto: stm32: convert to the new crypto engine API
crypto/crypto_engine.c | 188 ++++++---------------------
drivers/crypto/omap-aes.c | 21 ++-
drivers/crypto/omap-aes.h | 3 +
drivers/crypto/omap-des.c | 24 +++-
drivers/crypto/stm32/stm32-hash.c | 22 +++-
drivers/crypto/virtio/virtio_crypto_algs.c | 15 ++-
drivers/crypto/virtio/virtio_crypto_common.h | 2 +-
drivers/crypto/virtio/virtio_crypto_core.c | 3 -
include/crypto/engine.h | 46 +++----
9 files changed, 122 insertions(+), 202 deletions(-)
--
2.13.6
next reply other threads:[~2017-11-29 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 8:41 Corentin Labbe [this message]
2017-11-29 8:41 ` [PATCH RFC 1/4] " Corentin Labbe
2017-12-06 11:02 ` Fabien DESSENNE
2017-12-07 9:24 ` Corentin Labbe
2017-12-22 6:57 ` Herbert Xu
2017-12-22 8:41 ` Corentin Labbe
2017-12-22 9:06 ` Herbert Xu
2017-12-22 9:34 ` Corentin Labbe
2017-11-29 8:41 ` [PATCH RFC 2/4] crypto: omap: convert to new crypto engine API Corentin Labbe
2017-11-29 8:41 ` [PATCH RFC 3/4] crypto: virtio: " Corentin Labbe
2017-11-29 8:41 ` [PATCH RFC 4/4] crypto: stm32: convert to the " Corentin Labbe
2017-12-06 11:03 ` Fabien DESSENNE
2017-12-06 10:59 ` [PATCH RFC 0/4] crypto: engine - Permit to enqueue all async requests Fabien DESSENNE
2017-12-07 9:37 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129084121.9385-1-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=arei.gonglei@huawei.com \
--cc=davem@davemloft.net \
--cc=fabien.dessenne@st.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®