From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932804AbdK2OxP (ORCPT ); Wed, 29 Nov 2017 09:53:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:60626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbdK2OxM (ORCPT ); Wed, 29 Nov 2017 09:53:12 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E9FB218DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 29 Nov 2017 09:53:09 -0500 From: Steven Rostedt To: Vladislav Valtchev Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com Subject: Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record() Message-ID: <20171129095309.6e0a445a@gandalf.local.home> In-Reply-To: <1511893066.1754.8.camel@gmail.com> References: <20171123163335.19078-1-vladislav.valtchev@gmail.com> <20171123163335.19078-5-vladislav.valtchev@gmail.com> <20171128114822.0f80ed1e@gandalf.local.home> <1511893066.1754.8.camel@gmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Nov 2017 20:17:46 +0200 Vladislav Valtchev wrote: > On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote: > > > > Is there a reason that init_instance() isn't called in > > init_common_record_context()? > > > > Hi Steven, > > init_instance() has been put into init_common_record_context() later, > in patch 8, "Making start,extract,stream,profile separate funcs". I have to ask. Why isn't it done in this patch. This patch appears to be the proper place to put it. -- Steve