From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbdK2K72 (ORCPT ); Wed, 29 Nov 2017 05:59:28 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34178 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbdK2K70 (ORCPT ); Wed, 29 Nov 2017 05:59:26 -0500 X-Google-Smtp-Source: AGs4zMYI76sWOI3aY/lRIYxCdfKP2A/TpRzpqgvVps/+zgPWR+y9LPa6a/ZDbFeiGxswxHxrc5DrGg== Date: Wed, 29 Nov 2017 10:59:22 +0000 From: Lee Jones To: Colin King Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mfd: ti_am335x_tscadc: remove redundant assignment to node Message-ID: <20171129105922.7fd6jsmlry4sxvhj@dell> References: <20171029125851.5727-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171029125851.5727-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Oct 2017, Colin King wrote: > From: Colin Ian King > > Node is being initialized a value that is never read, it is > being written over a few statements into the function with > the return value from call to of_get_child_by_name. Hence > this initialization can be removed. Cleans up clang warning: > > drivers/mfd/ti_am335x_tscadc.c:127:22: warning: Value stored > to 'node' during its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/mfd/ti_am335x_tscadc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog