From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755512AbdK2PhS (ORCPT ); Wed, 29 Nov 2017 10:37:18 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:39325 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933185AbdK2PhQ (ORCPT ); Wed, 29 Nov 2017 10:37:16 -0500 Date: Wed, 29 Nov 2017 16:37:12 +0100 From: Andrew Lunn To: Corentin Labbe Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, wens@csie.org, peppe.cavallaro@st.com, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Message-ID: <20171129153712.GA24881@lunn.ch> References: <20171128164822.29218-1-clabbe.montjoie@gmail.com> <20171128173826.GE14512@lunn.ch> <20171129090240.GA3699@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129090240.GA3699@Red> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > the binding doc expect it to be in MAC node. > > > > > > Since all board DT use it also in MAC node, the driver need to search > > > allwinner,leds-active-low in MAC node. > > > > Hi Corentin > > > > I'm having trouble working out how this worked before. This is code > > you moved around, when adding external/internal MDIOs. But the very > > first version of this driver code used priv->plat->phy_node. Did that > > somehow point to the MAC node when the internal PHY is used? Or has it > > been broken all the time? > > > > Hello > > Since this feature control only when the activity LED need to blink, > nobody see that it was broken. Hi Corentin So it never worked? If it never worked, moving the DT properties into the PHY node, where they belong, won't introduce a regression :-) Andrew