From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933536AbdK2Prj (ORCPT ); Wed, 29 Nov 2017 10:47:39 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:36867 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932299AbdK2Prf (ORCPT ); Wed, 29 Nov 2017 10:47:35 -0500 Date: Wed, 29 Nov 2017 16:47:33 +0100 From: Maxime Ripard To: Andrew Lunn Cc: Corentin Labbe , alexandre.torgue@st.com, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, wens@csie.org, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling Message-ID: <20171129154733.gersgylwvgrdam26@flea.lan> References: <20171128164822.29218-1-clabbe.montjoie@gmail.com> <20171128173826.GE14512@lunn.ch> <20171129090240.GA3699@Red> <20171129153712.GA24881@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7wrefm2bjgpefdvb" Content-Disposition: inline In-Reply-To: <20171129153712.GA24881@lunn.ch> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7wrefm2bjgpefdvb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2017 at 04:37:12PM +0100, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > > the binding doc expect it to be in MAC node. > > > >=20 > > > > Since all board DT use it also in MAC node, the driver need to sear= ch > > > > allwinner,leds-active-low in MAC node. > > >=20 > > > Hi Corentin > > >=20 > > > I'm having trouble working out how this worked before. This is code > > > you moved around, when adding external/internal MDIOs. But the very > > > first version of this driver code used priv->plat->phy_node. Did that > > > somehow point to the MAC node when the internal PHY is used? Or has it > > > been broken all the time? > > >=20 > >=20 > > Hello > >=20 >=20 > > Since this feature control only when the activity LED need to blink, > > nobody see that it was broken. >=20 > Hi Corentin >=20 > So it never worked? >=20 > If it never worked, moving the DT properties into the PHY node, where > they belong, won't introduce a regression :-) That's even truer since it's been queued for 4.15 which hasn't been released yet. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --7wrefm2bjgpefdvb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAloe1pIACgkQ0rTAlCFN r3ThPBAAlkCW6K3lApduvE+qP14RrgxSrKPhyzUad0qeh7HIX1nAagGNtAhk+MXV HmXYXc8QzC2i/xzpldd7Q3NwIQG4E7spS3J1McSbQbwimZr21xis/06d+VMSD4EY LYwJwNLNejeTsp47gEcV/xUAaPAPsiUQRuv2oJ7r+5gOVrVDTiKJv9Fyx77m0KtI ApDVuRu0vbwhLJ4wz4JdPECkDMN3E/pG9sf33ETb0BNSmoYWnDHRMxGZuTLqiraQ u7c6YUmhD11OAXpwPsvWnDYgkA6URGE12EBYgP/sxJq0mIakUioxC7MN2yizmoKt M5sd/c1LcmZ8m0XTcyFJjkcS9xC+CWCBJwjEMjTEX/jxmixFVJw+PXdQ5cif6+Nu 9uMbE7+/zDhV1QOmezb5BMxUBzKSg9l1yhPdKvFbmbzEjpjWXfHrYn1oaPFxE3SR /JSGaK7jyHhHhyUlv/8l8DQRR9/2iqjYr7TAwLMrHZG9oV02j3N4FMpwRUM5+pTE Y4WW3DFMj7GLWjI9tbuOS2e4wtPvtrVu8Htr1aAjRr0pdegjVvqjxbrpuiey862u PZHh7/8EeRnocc5Qne1i5n4mP5ELHVayYBFrJTQgsQAybc1NbIH9pGaoYiKlID0P s3MHIgzy1RJpwXnYeb/s08igdnsM1rrFJIASADKms3fIE3/CNVY= =99ys -----END PGP SIGNATURE----- --7wrefm2bjgpefdvb--