From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933458AbdK2Psh (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 10:48:37 -0500
Received: from mx2.suse.de ([195.135.220.15]:42503 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932299AbdK2Psg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 10:48:36 -0500
Date: Wed, 29 Nov 2017 16:48:33 +0100
From: Jan Kara <jack@suse.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>
Subject: Re: [PATCH] quota: Check for register_shrinker() failure.
Message-ID: <20171129154833.GA28256@quack2.suse.cz>
References: <1511962490-3771-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
 <20171129134251.ecyp3zz3gblmbziy@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171129134251.ecyp3zz3gblmbziy@dhcp22.suse.cz>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed 29-11-17 14:42:51, Michal Hocko wrote:
> On Wed 29-11-17 22:34:50, Tetsuo Handa wrote:
> > register_shrinker() might return -ENOMEM error since Linux 3.12.
> > Call panic() as with other failure checks in this function if
> > register_shrinker() failed.
> > 
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> 
> Fixes: 1d3d4437eae1 ("vmscan: per-node deferred work")
> 
> > Cc: Jan Kara <jack@suse.com>
> > Cc: Michal Hocko <mhocko@suse.com>
> 
> From my very limited understanding of the code this looks correct.
> FWIW
> Reviewed-by: Michal Hocko <mhocko@suse.com>

Thanks. Added to my tree.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR