From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933572AbdK2Q3h (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 11:29:37 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:48411 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932094AbdK2Q3g (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 11:29:36 -0500
Date: Wed, 29 Nov 2017 08:29:16 -0800
From: Matthew Wilcox <willy@infradead.org>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
        Chris Mi <chrism@mellanox.com>, Jiri Pirko <jiri@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Eric Biggers <ebiggers@google.com>,
        Lai Jiangshan <laijs@cn.fujitsu.com>, Tejun Heo <tj@kernel.org>,
        Rehas Sachdeva <aquannie@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32
Message-ID: <20171129162916.GA18402@bombadil.infradead.org>
References: <20171128213312.28983-1-willy@infradead.org>
 <20171128213312.28983-12-willy@infradead.org>
 <20171128170817.1c23d420@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171128170817.1c23d420@cakuba.netronome.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote:
> On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
> > +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> > +						INT_MAX, GFP_KERNEL);
> > +	} else if (!oldprog) {
> > +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> > +						handle, GFP_KERNEL);
> 
> nit: in many places you seem to not align the second line with opening
> parenthesis.  Is that intentional?

It's more that I don't care.  I press 'enter', which indents the arguments
by a certain amount, then press the 'tab' key until it looks aesthetically
pleasing.

> FWIW there may be a small merge conflict with net on cls_bpf in patch
> 5, some of the code has been removed.

Thanks.  Dave, do you want to take the IDR patches through your tree to
save conflict resolution?