From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933654AbdK2QaX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 11:30:23 -0500
Received: from imap.thunk.org ([74.207.234.97]:42776 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932094AbdK2QaT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 11:30:19 -0500
Date: Wed, 29 Nov 2017 11:29:45 -0500
From: "Theodore Ts'o" <tytso@mit.edu>
To: David Miller <davem@davemloft.net>
Cc: gnomes@lxorguk.ukuu.org.uk, keescook@chromium.org, mcgrof@kernel.org,
        tixxdz@gmail.com, luto@kernel.org, akpm@linux-foundation.org,
        james.l.morris@oracle.com, ben.hutchings@codethink.co.uk,
        solar@openwall.com, serge@hallyn.com, jeyu@kernel.org,
        rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        kernel-hardening@lists.openwall.com, corbet@lwn.net, mingo@kernel.org,
        netdev@vger.kernel.org, peterz@infradead.org,
        torvalds@linux-foundation.org
Subject: Re: [PATCH v5 next 1/5] modules:capabilities: add
 request_module_cap()
Message-ID: <20171129162945.u2zjcoe4gsanhmkc@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        David Miller <davem@davemloft.net>, gnomes@lxorguk.ukuu.org.uk,
        keescook@chromium.org, mcgrof@kernel.org, tixxdz@gmail.com,
        luto@kernel.org, akpm@linux-foundation.org,
        james.l.morris@oracle.com, ben.hutchings@codethink.co.uk,
        solar@openwall.com, serge@hallyn.com, jeyu@kernel.org,
        rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        kernel-hardening@lists.openwall.com, corbet@lwn.net,
        mingo@kernel.org, netdev@vger.kernel.org, peterz@infradead.org,
        torvalds@linux-foundation.org
References: <20171129134612.72ccb53d@alans-desktop>
 <20171129.095014.1909386937628805919.davem@davemloft.net>
 <20171129155406.i2lyclquj75lvtn4@thunk.org>
 <20171129.105816.1108278026315471171.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171129.105816.1108278026315471171.davem@davemloft.net>
User-Agent: NeoMutt/20170609 (1.8.3)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 29, 2017 at 10:58:16AM -0500, David Miller wrote:
> That's not what we're talking about.
> 
> We're talking about making sure that loading "ppp.ko" really gets
> ppp.ko rather than some_other_module.ko renamed to ppp.ko via some
> other mechanism.

Right, and the best solution to this problem is to include in the
signature the name of the module.  (One way of doing this is adding
the module name into the cryptographic checksum which is then
digitally signed by the kernel module key; we would have to bump the
version number of the signature format, obviously.)  This binds the
name of the module into the digital signature so that it can't be
renamed.

						- Ted