From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdK2Shk (ORCPT ); Wed, 29 Nov 2017 13:37:40 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:40503 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdK2Shh (ORCPT ); Wed, 29 Nov 2017 13:37:37 -0500 X-Google-Smtp-Source: AGs4zMaGagpuB4Z6byjmcI1DsdR1yCtiJEoFX6tTzirrdREHMyRXhcX/sJCyUQAFk+0+GEIh5OilWA== Date: Wed, 29 Nov 2017 10:37:33 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com, Doug Anderson Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399 Message-ID: <20171129183732.GA74243@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511868006-27130-6-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Doug, since he was asking these things elsewhere On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote: > This patch update mipi node for RK3399 DSI controller > based on the Synopsys DesignWare MIPI DSI host controller. > > Signed-off-by: Nickey Yang > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index d340b58a..0ac67a9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1652,9 +1652,11 @@ > status = "disabled"; > > ports { > - mipi_in: port { > - #address-cells = <1>; > - #size-cells = <0>; > + #address-cells = <1>; > + #size-cells = <0>; ^^ It's good to add these here, since child nodes are going to have unit addresses. > + > + mipi_in: port@0 { > + reg = <0>; ^^ But you're removing the #{address,size}-cells from the port, while still using unit addresses on its subnodes (the endpoint@... nodes). You should keep *both*, since both the 'ports' node and the 'port@0' node will have children with addresses. Brian > > mipi_in_vopb: endpoint@0 { > reg = <0>; > -- > 1.9.1 >