From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Josh Poimboeuf <jpoimboe@redhat.com>, Yonghong Song <yhs@fb.com>,
Alexei Starovoitov <ast@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Wang Nan <wangnan0@huawei.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: Re: 'perf test BPF' failing, libbpf regression wrt "basic API for BPF obj name"
Date: Wed, 29 Nov 2017 18:15:43 -0300 [thread overview]
Message-ID: <20171129211543.GC31403@kernel.org> (raw)
In-Reply-To: <20171129210734.lqs23q65ac6avlwr@kafai-mbp>
Em Wed, Nov 29, 2017 at 01:07:34PM -0800, Martin KaFai Lau escreveu:
> On Tue, Nov 28, 2017 at 04:05:19PM -0300, Arnaldo Carvalho de Melo wrote:
> >
> > [root@jouet ~]# perf test -v bpf
> > 39: BPF filter :
> > 39.1: Basic BPF filtering :
> > --- start ---
> > test child forked, pid 12198
> > Kernel build dir is set to /lib/modules/4.14.0+/build
> > set env: KBUILD_DIR=/lib/modules/4.14.0+/build
> [ ... ]
> > libbpf: failed to create map (name: 'flip_table'): Invalid argument
> > libbpf: failed to load object '[basic_bpf_test]'
> > bpf: load objects failed
> 88cda1c9da02 ("bpf: libbpf: Provide basic API support to specify BPF obj name")
> is introduced in 4.15.
> I think the perf@kernel-4.15 broke on older kernels like 4.14 because
> the new bpf prog/map name is only introduced since 4.15.
> The newer perf needs to be compatible with an older kernel?
Sure :-)
If some ABI breaks it should detect that and adapt, and older perf
tools should also gracefully fail in such a case, which I'm not sure
will be the case here, haven't checked perf's BPF integration to see how
it behaves in such a case, but I will.
- Arnaldo
next prev parent reply other threads:[~2017-11-29 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 19:05 Arnaldo Carvalho de Melo
2017-11-29 21:07 ` Martin KaFai Lau
2017-11-29 21:15 ` Arnaldo Carvalho de Melo [this message]
2017-11-29 22:31 ` Martin KaFai Lau
2017-11-30 3:01 ` Arnaldo Carvalho de Melo
2017-11-30 16:53 ` [PATCH/RFC] " Arnaldo Carvalho de Melo
2017-11-30 18:28 ` Martin KaFai Lau
2017-11-30 19:00 ` Arnaldo Carvalho de Melo
2017-11-30 21:51 ` Alexei Starovoitov
2017-12-01 17:51 ` Arnaldo Carvalho de Melo
2017-12-02 1:15 ` Alexei Starovoitov
2017-11-30 22:09 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129211543.GC31403@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=aryabinin@virtuozzo.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome