mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <Anna.Schumaker@Netapp.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4
Date: Wed, 29 Nov 2017 21:58:53 -0500	[thread overview]
Message-ID: <20171129215853.20172851@vmware.local.home> (raw)

Just letting you know that this commit:

fcd8843c406 ('NFSv4: Replace closed stateids with the "invalid special
stateid"') causes gcc 4.5.4 to fail the build with this error:

  CC [M]  fs/nfs/nfs4state.o
/work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: error: field name not in record or union initializer
/work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: error: (near initialization for 'invalid_stateid.<anonymous>.data')
/work/git/linux-trace.git/fs/nfs/nfs4state.c:75:4: warning: overflow in implicit constant conversion
/work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: error: field name not in record or union initializer
/work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: error: (near initialization for 'invalid_stateid.<anonymous>.data')
/work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: warning: braces around scalar initializer
/work/git/linux-trace.git/fs/nfs/nfs4state.c:76:4: warning: (near initialization for 'invalid_stateid.<anonymous>.data[1]')
make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:310: fs/nfs/nfs4state.o] Error 1
make[2]: *** [/work/git/linux-trace.git/scripts/Makefile.build:569: fs/nfs] Error 2
make[1]: *** [/work/git/linux-trace.git/Makefile:1012: fs] Error 2
make[1]: Leaving directory '/work/git/nobackup/bxtest/trace'

Seems it can't handle the initialization of an anonymous struct within
an anonymous union.

I switched to gcc 4.6.3 and it compiles fine.

-- Steve

             reply	other threads:[~2017-11-30  2:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  2:58 Steven Rostedt [this message]
2017-11-30  3:27 ` Linus Torvalds
2017-11-30  3:39   ` Andrew Morton
2017-11-30  3:44     ` Linus Torvalds
2017-11-30  3:48       ` Andrew Morton
2017-11-30  4:05       ` Steven Rostedt
2017-11-30 11:46         ` Trond Myklebust
2017-11-30 13:05           ` Anna Schumaker
2017-11-30 12:28     ` Arnd Bergmann
2017-11-30 15:55       ` Marc Zyngier
2017-11-30 10:33 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129215853.20172851@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®