From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbdK3EFc (ORCPT ); Wed, 29 Nov 2017 23:05:32 -0500 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:40644 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753148AbdK3EFb (ORCPT ); Wed, 29 Nov 2017 23:05:31 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3872:4321:5007:6119:6120:6261:7875:7901:7903:10004:10400:10450:10455:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12555:12740:12760:12895:13069:13101:13311:13357:13439:14181:14659:14721:19904:19999:21080:21434:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: vase40_6a36023bc5532 X-Filterd-Recvd-Size: 2739 Date: Wed, 29 Nov 2017 23:05:28 -0500 From: Steven Rostedt To: Linus Torvalds Cc: Andrew Morton , LKML , Trond Myklebust , Anna Schumaker Subject: Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 Message-ID: <20171129230528.6955b58a@vmware.local.home> In-Reply-To: References: <20171129215853.20172851@vmware.local.home> <20171129193927.e4248d8a797b90aa03edd0ff@linux-foundation.org> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2017 19:44:33 -0800 Linus Torvalds wrote: I keep older compilers around to test ftrace before -mfentry was introduced. I wonder if I should just add a config to force the use without -mfentry even if the compiler supports it. > fs/nfs/nfs4state.c | 3 +-- > include/linux/nfs4.h | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > index 54fd56d715a8..9db5d0d57fcb 100644 > --- a/fs/nfs/nfs4state.c > +++ b/fs/nfs/nfs4state.c > @@ -71,8 +71,7 @@ const nfs4_stateid zero_stateid = { > }; > const nfs4_stateid invalid_stateid = { > { > - .seqid = cpu_to_be32(0xffffffffU), > - .other = { 0 }, > + { .seqid = cpu_to_be32(0xffffffffU), .other = { 0 }, }, I tried this and it failed. > }, > .type = NFS4_INVALID_STATEID_TYPE, > }; > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h > index 47adac640191..e394ba0cd6c5 100644 > --- a/include/linux/nfs4.h > +++ b/include/linux/nfs4.h > @@ -53,11 +53,11 @@ typedef struct { char data[NFS4_VERIFIER_SIZE]; } nfs4_verifier; > > struct nfs4_stateid_struct { > union { > - char data[NFS4_STATEID_SIZE]; > struct { > __be32 seqid; > char other[NFS4_STATEID_OTHER_SIZE]; > } __attribute__ ((packed)); > + char data[NFS4_STATEID_SIZE]; But I didn't try this. This looks to be the key. This works for me. Tested-by: Steven Rostedt (VMware) -- Steve > }; > > enum {