From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbdK3TWO (ORCPT ); Thu, 30 Nov 2017 14:22:14 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49600 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbdK3TWN (ORCPT ); Thu, 30 Nov 2017 14:22:13 -0500 Date: Thu, 30 Nov 2017 14:22:11 -0500 (EST) Message-Id: <20171130.142211.758595133428105297.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: bcm_sf2: Set correct CHAIN_ID and slice number mask From: David Miller In-Reply-To: <20171130184526.13717-1-f.fainelli@gmail.com> References: <20171130184526.13717-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Nov 2017 11:22:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 30 Nov 2017 10:45:26 -0800 > When configuring an IPv6 address mask, we should use SLICE_NUM_MASK as > the mask in order to make sure all bits are masked by the hardware. > Also, we want matching entries to have a CHAIN_ID value set to the same > value as the rule index we return to user-space for convenience, so fix > that too. > > Fixes: ba0696c22e7c ("net: dsa: bcm_sf2: Add support for IPv6 CFP rules") > Fixes: dd8eff68343d ("net: dsa: bcm_sf2: Allow matching arbitrary IPv6 masks/lengths") > Signed-off-by: Florian Fainelli Applied, thanks Florian.