From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbdK3My3 (ORCPT ); Thu, 30 Nov 2017 07:54:29 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:55384 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbdK3My0 (ORCPT ); Thu, 30 Nov 2017 07:54:26 -0500 Date: Thu, 30 Nov 2017 12:54:17 +0000 From: Russell King - ARM Linux To: Maciej Purski Cc: Greg Kroah-Hartman , Marek Szyprowski , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] component: add debugfs support Message-ID: <20171130125416.GB10595@n2100.armlinux.org.uk> References: <1512046112-9474-1-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512046112-9474-1-git-send-email-m.purski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 01:48:32PM +0100, Maciej Purski wrote: > Currently there is no information in any vfs about which devices > a master component consists of, what makes debugging hard if > one of the component devices fails to register. > > Add 'device_component' directory to debugfs. Create a new file for each > component master, when it has been added. Remove it on a master > deletion. Show a list of devices required by the given master and their > status (registered or not). This provides an easy way to check, which > device has failed to register if the given master device is not > available in the system. > > Signed-off-by: Maciej Purski > --- > Changes in v4: > - fix and expand commit message > - inline no-op functions inline on static functions makes no sense - the compiler itself is at liberty to inline any static function that it thinks would benefit, and it is likely to do so with such a simple function. Generally we prefer to omit "inline" in .c files and let the compiler decide whether to inline or not. What was the reason for making this change? Do you have a case where this doesn't happen? -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up