From: "Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com>
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com,
"Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com>
Subject: [PATCH v2 07/10] trace-cmd: Mov init_common_record_context in parse_record_options
Date: Thu, 30 Nov 2017 15:19:54 +0200 [thread overview]
Message-ID: <20171130131957.21617-8-vladislav.valtchev@gmail.com> (raw)
In-Reply-To: <20171130131957.21617-1-vladislav.valtchev@gmail.com>
This short patch moves init_common_record_context() into parse_record_option()
after checking that no trace_* function in trace-record.c really needs to do
work after init_common_record_context() but before parse_record_option().
In particular, two statements in trace_profile() have been moved after the
call of parse_record_option(), since they did not actually affect it.
Signed-off-by: Vladislav Valtchev (VMware) <vladislav.valtchev@gmail.com>
---
trace-record.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/trace-record.c b/trace-record.c
index 55e81cf..7688565 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -4405,6 +4405,7 @@ static void init_common_record_context(struct common_record_context *ctx,
static void parse_record_options(int argc,
char **argv,
+ enum trace_cmd curr_cmd,
struct common_record_context *ctx)
{
const char *plugin = NULL;
@@ -4416,6 +4417,8 @@ static void parse_record_options(int argc,
char *sav;
int neg_event = 0;
+ init_common_record_context(ctx, curr_cmd);
+
for (;;) {
int option_index = 0;
int ret;
@@ -4925,8 +4928,7 @@ void trace_start(int argc, char **argv)
{
struct common_record_context ctx;
- init_common_record_context(&ctx, CMD_start);
- parse_record_options(argc, argv, &ctx);
+ parse_record_options(argc, argv, CMD_start, &ctx);
record_trace(argc, argv, &ctx);
exit(0);
}
@@ -4935,8 +4937,7 @@ void trace_extract(int argc, char **argv)
{
struct common_record_context ctx;
- init_common_record_context(&ctx, CMD_extract);
- parse_record_options(argc, argv, &ctx);
+ parse_record_options(argc, argv, CMD_extract, &ctx);
record_trace(argc, argv, &ctx);
exit(0);
}
@@ -4945,8 +4946,7 @@ void trace_stream(int argc, char **argv)
{
struct common_record_context ctx;
- init_common_record_context(&ctx, CMD_stream);
- parse_record_options(argc, argv, &ctx);
+ parse_record_options(argc, argv, CMD_stream, &ctx);
record_trace(argc, argv, &ctx);
exit(0);
}
@@ -4955,13 +4955,11 @@ void trace_profile(int argc, char **argv)
{
struct common_record_context ctx;
- init_common_record_context(&ctx, CMD_profile);
+ parse_record_options(argc, argv, CMD_profile, &ctx);
handle_init = trace_init_profile;
ctx.events = 1;
- parse_record_options(argc, argv, &ctx);
-
/*
* If no instances were set, then enable profiling on the top instance.
*/
@@ -4977,8 +4975,7 @@ void trace_record(int argc, char **argv)
{
struct common_record_context ctx;
- init_common_record_context(&ctx, CMD_record);
- parse_record_options(argc, argv, &ctx);
+ parse_record_options(argc, argv, CMD_record, &ctx);
record_trace(argc, argv, &ctx);
exit(0);
}
--
2.14.1
next prev parent reply other threads:[~2017-11-30 13:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:19 [PATCH v2 00/10] trace-cmd: Refactoring trace_record() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 01/10] trace-cmd: Extract parse_record_options() from trace_record() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 02/10] trace-cmd: Replacing cmd flags w/ a trace_cmd enum Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 03/10] trace-cmd: Extracting record_trace() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 04/10] trace-cmd: Rename trace_profile() to do_trace_profile() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 05/10] trace-cmd: Making start,extract,stream,profile separate funcs Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 06/10] trace-cmd: Extr. profile-specific code from record_trace Vladislav Valtchev (VMware)
2017-11-30 17:05 ` Steven Rostedt
2017-12-01 11:10 ` Vladislav Valtchev
2017-11-30 13:19 ` Vladislav Valtchev (VMware) [this message]
2017-11-30 17:07 ` [PATCH v2 07/10] trace-cmd: Mov init_common_record_context in parse_record_options Steven Rostedt
2017-12-01 11:20 ` Vladislav Valtchev
2017-11-30 13:19 ` [PATCH v2 08/10] trace-cmd: Introducing get_trace_cmd_type() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 09/10] trace-cmd: Extract finalize_record_trace() Vladislav Valtchev (VMware)
2017-11-30 13:19 ` [PATCH v2 10/10] trace-cmd: Fork record_trace() for the extract case Vladislav Valtchev (VMware)
2017-11-30 21:37 ` [PATCH v2 00/10] trace-cmd: Refactoring trace_record() Steven Rostedt
2017-12-01 10:46 ` Vladislav Valtchev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130131957.21617-8-vladislav.valtchev@gmail.com \
--to=vladislav.valtchev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®