From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752451AbdK3N5a (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 08:57:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52558 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751065AbdK3N53 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 08:57:29 -0500
Date: Thu, 30 Nov 2017 07:57:27 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, xiaolong.ye@intel.com,
        fengguang.wu@intel.com
Subject: Re: [PATCH] x86/unwind_guess: Prevent using UNWINDER_GUESS=y with
 STACKDEPOT=y
Message-ID: <20171130135727.zy3nfdeodtkybzff@treble>
References: <20171130123554.4330-1-aryabinin@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171130123554.4330-1-aryabinin@virtuozzo.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 30 Nov 2017 13:57:29 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 30, 2017 at 03:35:54PM +0300, Andrey Ryabinin wrote:
> Stackdepot doesn't work well with CONFIG_UNWINDER_GUESS=y.
> The 'guess' unwinder generate awfully large and inaccurate stacktraces,
> thus stackdepot can't deduplicate stacktraces because they all look like
> unique. Eventually stackdepot reaches its capacity limit:
> 
> WARNING: CPU: 0 PID: 545 at lib/stackdepot.c:119 depot_save_stack+0x28e/0x550
> Call Trace:
>  ? kasan_kmalloc+0x144/0x160
>  ? depot_save_stack+0x1f5/0x550
>  ? do_raw_spin_unlock+0xda/0xf0
>  ? preempt_count_sub+0x13/0xc0
> 
> <...90 lines...>
> 
>  ? do_raw_spin_unlock+0xda/0xf0
> 
> Add STACKDEPOT=n dependency to UNWINDER_GUESS to avoid the problem.
> 
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Reported-by: kernel test robot <xiaolong.ye@intel.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh