From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbdK3OUm (ORCPT ); Thu, 30 Nov 2017 09:20:42 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:52021 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdK3OUk (ORCPT ); Thu, 30 Nov 2017 09:20:40 -0500 From: Christoph Hellwig To: Ingo Molnar , eter Zijlstra Cc: Andrew Morton , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] epoll: use proper wake_up variant in ep_poll_callback Date: Thu, 30 Nov 2017 06:20:37 -0800 Message-Id: <20171130142037.19339-3-hch@lst.de> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171130142037.19339-1-hch@lst.de> References: <20171130142037.19339-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We do not hold ep->wq->lock, so we should not use wake_up_locked on it. Signed-off-by: Christoph Hellwig --- fs/eventpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index afd548ebc328..eaaa39616232 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1190,7 +1190,7 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v break; } } - wake_up_locked(&ep->wq); + wake_up(&ep->wq); } if (waitqueue_active(&ep->poll_wait)) pwake++; -- 2.14.2