From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753678AbdK3Qpb (ORCPT ); Thu, 30 Nov 2017 11:45:31 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:55184 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbdK3QpZ (ORCPT ); Thu, 30 Nov 2017 11:45:25 -0500 Date: Thu, 30 Nov 2017 16:44:52 +0000 From: Roman Gushchin To: David Ahern CC: , , , , , , Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command Message-ID: <20171130164445.GA4238@castle.DHCP.thefacebook.com> References: <20171130134302.2840-1-guro@fb.com> <20171130134302.2840-4-guro@fb.com> <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:d7c1] X-ClientProxiedBy: HE1PR0401CA0077.eurprd04.prod.outlook.com (2603:10a6:3:19::45) To DM3PR15MB1084.namprd15.prod.outlook.com (2603:10b6:0:12::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b22b9a79-805b-411e-57be-08d53811b6b3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603286);SRVR:DM3PR15MB1084; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;3:YiLAUx/Gq40W87+UD6OPRauUlCvVngTQApdHiC+Gr0/MU7VbN9kHQX1fI0ufHVvoN7aQ5612k7GuNxDincl1vYT7dco4RUpe8vmMMa6yHVr2WNnjBUoudbKeQDWAg6QrrhWFXu52nJvd5DlR1GBOXaPLJU0RkdCoS405G5ZfZXXSy6jbsXTkYpU7UeH+CQK8hhUVqOUOacpYjoDk7/OTc7v1n8SBBHxIq0TyXJG94XfLDfzhnu638EJeOeldiwAi;25:hqHVNCrED02ahVetVjGaK3lR2ulZpwQQOEOA4eHIMs8Y4LLZ2pNJvjSkOBDuROMSZ+SqGnvd4CtIAyxG91IAfCb3+tLKxkkZXEWCuLis1w+vz1/hA69xP0uGh7VsHaCGBPUAOw63U1D+3N2prh3g3AaX7LLVGkO5JUayV+Y+QWpbwVpVR6jaZXaUjs6wWnfeRMFVOriQLOEkRmZ16lRjsRB1PBxyHf7r9Rwjih7PVbh5WRpt0X7Zz9j8YXAgBSrux6oLk3d6CJZyqYojrxd/VozbyhbqzqK6+PbHYGTLQpfIsazUEOKyZM0X3xUc8FYW9lu4BqInNE1w6eO7FFlWvg==;31:8HXemvI4IOH2HykGTpKJYkOP4qHLaMpiHwqSCJlWp1Dm6HlH8ePfg0uN7G+aGS37L6oibGSsqg+gT3fYqPKsUlzKQnZ56f+juaw+zQ4feL/9mb7IXw5sX3bLkiieoMfC1l9Bs5udYmd6PRBDhc9MC23pJihebHDxA33zvHGTMqCkiATxIY8h+mvpF7CBPGRhss+jWOTeTYCqPD9hVAtw4OB/2bW8Nl6z7uhkGKGLX24= X-MS-TrafficTypeDiagnostic: DM3PR15MB1084: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:G4ef3ztzjQohMSmoF4EU4JVSB3m7qQ3AVhNWi8jF1DMl1IHXLS8OdkFMsFyo4Lr1p/dt7qmGaVhuzmtthHzag6NGY6HK1UWKVrPp4UfVSVujFYgZ5VbGRGcxL3N6BsIMi8+GtQ4ajTt5ucRERD3m4ec2VFibt6W6NIHbHPK78vmdvGtWEBD+x7T2aJqODA1NocogIVZWX0YX6aMfBW7a+brpH3ess9gfkeLwM2uLRD5PsX31CDGSQxFjshnuT3q6mlDoPdsapN5OK5laXMdVKp1JbIRANUrkXkmGrvZhvIo5cPxQlSik3Al+TeQtoeNXpkddu6Dd2tsL2Avol5FoUKtO7vE+XPr4RQ6aekxzp95uC4tjyG3rq3Ul73ZGwLr1uKMONUCuKAh1H152WKWvpV2LEjFXYrbnuXFLDnHfCYU0bHx4er8KGwUHDU2SOMUBtWb2ezutvV5vPW1MvnU1XZDfuQgNdp7WpNTwZ8w1rHdV4tJhyn9zPDsWqYL0l9I7;4:pjxqU3s8Bbu2i8GCj2WcY+SJDU81cJmD5BAHqinX6oCwDcD/SjmnxUtiDbkTvNrGmkd2vKc7Zyrayxd2oTGgq4CQeMDtfmZetfV3VGqeZaauvtavg7Tl5E7NVIhT3RYGBVDy21gBzeZlQ0lG0IIghKrbSHVZKVDBOdDn3iiM5fvpwNgzxG0qTNrGNfOD+gn0jCdOKyatNmJZkDoCP7rfdLaKQ8zGmSzhW9AaPByiNnOMeyqaQ2jIDv8+7AQzphdqZJ8XkHWag6Djqg89ryNKdQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(10201501046)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011);SRVR:DM3PR15MB1084;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM3PR15MB1084; X-Forefront-PRVS: 05079D8470 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(366004)(346002)(376002)(189002)(199003)(24454002)(189998001)(33656002)(2906002)(47776003)(68736007)(1411001)(23726003)(6116002)(1076002)(101416001)(7736002)(305945005)(6246003)(9686003)(8676002)(5660300001)(6666003)(81166006)(52396003)(2950100002)(6916009)(81156014)(83506002)(5890100001)(6506006)(55016002)(229853002)(50466002)(316002)(97736004)(54356010)(76176010)(50986010)(86362001)(25786009)(58126008)(8936002)(105586002)(478600001)(106356001)(16586007)(53546010)(52116002)(53936002)(7696005)(39060400002)(4326008)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1084;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1084;23:5iO89clEUH6zX082N8Cu1F7t13Qz+Xbxbc5AFjonY?= =?us-ascii?Q?00fCKJjtxfpdcNX+wkb1GYZ6wYO2zNNU2+ursCjpV62MeQrFgKLIKXCv65W1?= =?us-ascii?Q?tPvdqGb3WG1DR8D/lsHi7D8f6ZDccFT5Ub9MvChUc2MpstV/LTXtiewDgaJD?= =?us-ascii?Q?ZIxdwD+cDpRNanivTM4RcjBhqVQo2cazzRp5wnlfaWFaJ4eJCcyqsgDgDsAr?= =?us-ascii?Q?hZ9tGlvmCodmLQeS+Pi3/soipq7i04/0j88tiimEi7vEz0whU3FEp/TWgz3I?= =?us-ascii?Q?c10FwqSFuxyDJs0ERc9WhWSnUQV0v5+KK3R5o/ks1TmBDRJDaiZr+ALjM6Pf?= =?us-ascii?Q?i2wtBy+RTBYj8aIjNxa0Pwfujh+442DdDKrc6fp0Fk/wovy314n/udhJ1XZt?= =?us-ascii?Q?i/C/K5n3mGZrsSZPcGx4n35FRVHtpzzZg1RoFhpS4GH31aDfMLG1z+PAa7hV?= =?us-ascii?Q?RoMFcq2SDQQH3L/5BcSF/HCBaitxLss4BPmwqqtYWgESgPFRsPxMzzxVRuol?= =?us-ascii?Q?MseNCHEOwh+UyRBF8pBDkxyiUYW38VoBWoIZQsZTuv5MKEoQWTjBKrWtJrU0?= =?us-ascii?Q?ByiTxgzza/t6tYntFxh0W1IItbjfxEuCfn0EmcPF+bxLoVy8wXrxr+hQuBLj?= =?us-ascii?Q?oPMR600bDSRd3y7tkL61oE+TC7BDCjFvtmJRig2LqJB96M7AkbKX+wYPckdq?= =?us-ascii?Q?ecXL7gjSYwQS18yzAeb1b8Wqw/42jNqbXtfOjSCfmL3J8hrgVn1KFIvuakcR?= =?us-ascii?Q?zyb/vPZlHgfw9irvgq5D6S2AfgOBB2Vcah2YTiqPgjaNIZXuycsArbBzH9CX?= =?us-ascii?Q?m+rP39Gx+juSzR1+iYt5yEvc/T/hlbyAmwFh+Lz7JRj5kuzbTY8e0kY9fh6O?= =?us-ascii?Q?We5/U/q9zqlTcmkzSGqVar7wtZxYZ6/F8NNO1VTivfHEHlz/ZNWpevXPEz3w?= =?us-ascii?Q?i9DoGRPgVKHbcoaWUFTYxcpfwGjL4N8vopDt0/XtT+ug2lXgq7Ndf1LknRGv?= =?us-ascii?Q?OzsOKMkle4Cx922NWyWhhiGJ46oSIxp/A2jUlMi45h4fbRESnogl9d27gEF1?= =?us-ascii?Q?Np8uISIohAXttGlFdDc7zacVy37MXmvtJuVe8REsP2RCImVoJisNxinptYS7?= =?us-ascii?Q?svgNz2/rV4QKwE9V2XhrOAXFtIrx+mTSy6TNKU3nOzEwa36dI9tENyuwuDV6?= =?us-ascii?Q?62e7P7EEj4IRB+k9EoKfVi6AjeAi03ddV8iUcE3zHB1/QuYaM/tD+BoVqaM3?= =?us-ascii?Q?DyMLu43paVnsXDK1GWCZWKhgPX2nA56JCo0BEZaK99QinARg2++YN1E8/ROg?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;6:v0XLrEc9zA/hXxyAvOaWBqhoeQDIPyidoLQI9fEMKpl2DKCg1pvgCkgjNvGnuk55LAz04bRm5U0usq6IsX5EeipIeD2h4ge2gepQ7r1igj2t2aG5Qndr/XmEtewM/upPjSYkboArQNHvb8Bahx06LHs/ul/iXutT626LCR8S+CxG7lexlzl/pTM1ToW7gDzJOuTwtxqIGuPH41cPxh2ILmmyduTUIu35fnuS/iIRqnTKO0VT8CggEK5HzcavyktDWVwVy8m1tjRLb0LlgrYiZHcRKAZAsUFkUK6ALlj83T0abPQhuAN8LVP6/YUb0x0M9ZDckqceItZnXZXw1iTjEl49BdvP6GS322+sF+ujfzg=;5:95Hryrz7CHMhymexUkTJ19ba49fziHuyo/zyeOZFIYfbZawc0G4/zYFTlu9KMNqH8ymEsjBVEGy5xjcCFgkMMFgUrg5e0kIAFPlJuHGF3rYiFIKo/HxbhBKkBtMC/HdIoo8wEdgE7NFoEFzT6UO5fQCl/7p/1tr9gZc0IGxAcKI=;24:+qLQLhcCts95/G63BGobbPh1iNKipoQaEhMF1y5bb/9Jp+gyVSyU63d2IrzfrDwuE6wzinXZBQjyjDsptd1SDUJpnGU5CPqFH42qsHGwEBY=;7:hkQ+T+6O34tEDxBwM6RAluIN0/NZlCoH14RCiA9LHk1zKM95feAoTfW1gogrJbW7Mr4f1pd1boxuSKiVhQzNPW4rbUMHiyFehOEvzjS9rbyR5PGXQR5ps6Pph+nBB1SmBW3TjD+y56EbXVlvBOpKHEUOUwRoyjC1w7dqv2xmJ3v8DNeMr9EOs1Ln5zVm0eXuHJlskYFYIoaehdycoOs9JdeO4irs+/j5U1nXfuPI6QkaHaQZkSEbWT8wbY6leKGe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1084;20:nivhSddX4HmV+6VWJ769cfV1OYI5ligeHt+VQGYc0g6PSQV4vrGShiuRqgUq+elq0j8BVcN7jUtQarmlY7qQw26JQq5dxKyhJ+mgo7p2QVsYS0Tx1BYp9Bot/tCuwcjzYi3wrmDSYCbyV6sCnpm4IL9HxFdB3lyyu418PeLGaGg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 16:45:05.2973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b22b9a79-805b-411e-57be-08d53811b6b3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1084 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-30_05:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 09:17:17AM -0700, David Ahern wrote: > On 11/30/17 6:43 AM, Roman Gushchin wrote: > > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > > fprintf(stderr, > > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > > " %s batch file FILE\n" > > + " %s cgattach FILE CGROUP TYPE\n" > > Can you change the order to: > + " %s cgattach CGROUP TYPE FILE\n" > > Makes for better consistency with the detach command in the next patch: > + " %s cgdetach CGROUP TYPE ID\n" > > Good point. I'll fix this and will add support for attach_flags in v2. Thanks!