From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbdK3Q63 (ORCPT ); Thu, 30 Nov 2017 11:58:29 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:38025 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbdK3Q62 (ORCPT ); Thu, 30 Nov 2017 11:58:28 -0500 X-Google-Smtp-Source: AGs4zMYoQU1mM5fDacYWxuhle1J9gd3wd9GNmqCBVDmBDlzyxsiebGyjQYmMnhGnN3u4XWvwBujSAQ== Date: Thu, 30 Nov 2017 08:58:24 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller Message-ID: <20171130165823.GA140320@google.com> References: <1511868006-27130-1-git-send-email-nickey.yang@rock-chips.com> <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511868006-27130-4-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 07:20:04PM +0800, Nickey Yang wrote: > This patch update documentation of device tree bindings for the rockchip > DSI controller based on the Synopsys DesignWare MIPI DSI host controller. It might help to describe why you're doing this. Just saying "update" is pretty vague. In this case, it's something like "describe panel/port links, including unit addresses". > > Signed-off-by: Nickey Yang > --- > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > index 6bb59ab..336909d 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > @@ -14,6 +14,8 @@ Required properties: > - rockchip,grf: this soc should set GRF regs to mux vopl/vopb. > - ports: contain a port node with endpoint definitions as defined in [2]. > For vopb,set the reg = <0> and set the reg = <1> for vopl. > +- video port 0 for the VOP input, the remote endpoint maybe vopb or vopl > +- video port 1 for either a panel or subsequent encoder > > Optional properties: > - power-domains: a phandle to mipi dsi power domain node. > @@ -40,11 +42,10 @@ Example: > ports { > #address-cells = <1>; > #size-cells = <0>; > - reg = <1>; > > - mipi_in: port { > - #address-cells = <1>; > - #size-cells = <0>; ^^ You're removing #{address,size}-cells here, but then port@0 will still have subnodes that have 'reg' properties, so I think you need to keep the -cells properties. Brian > + mipi_in: port@0 { > + reg = <0>; > + > mipi_in_vopb: endpoint@0 { > reg = <0>; > remote-endpoint = <&vopb_out_mipi>; > @@ -54,6 +55,14 @@ Example: > remote-endpoint = <&vopl_out_mipi>; > }; > }; > + > + mipi_out: port@1 { > + reg = <1>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&panel_in_mipi>; > + }; > + }; > }; > > panel { > @@ -64,5 +73,11 @@ Example: > pinctrl-names = "default"; > pinctrl-0 = <&lcd_en>; > backlight = <&backlight>; > + > + port { > + panel_in_mipi: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > }; > }; > -- > 1.9.1 >