From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751105AbdK3SzW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 13:55:22 -0500
Received: from merlin.infradead.org ([205.233.59.134]:42684 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750735AbdK3SzV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 13:55:21 -0500
Date: Thu, 30 Nov 2017 19:55:10 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches
Message-ID: <20171130185510.5s2a4pi4jwukbite@hirez.programming.kicks-ass.net>
References: <20171127104923.14378-1-mingo@kernel.org>
 <20171127104923.14378-16-mingo@kernel.org>
 <20171130154414.aekkjd26p3hxyqwa@hirez.programming.kicks-ass.net>
 <3ca0bea7-932a-6d91-a9b4-d07045d444f5@linux.intel.com>
 <20171130161844.v7ynfdggo6g7j5l5@hirez.programming.kicks-ass.net>
 <fd5bc34b-2bd2-13e2-b7e0-cf14e1c899f4@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fd5bc34b-2bd2-13e2-b7e0-cf14e1c899f4@linux.intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 30, 2017 at 10:44:40AM -0800, Dave Hansen wrote:
> On 11/30/2017 08:18 AM, Peter Zijlstra wrote:
> > On Thu, Nov 30, 2017 at 07:51:17AM -0800, Dave Hansen wrote:
> >> On 11/30/2017 07:44 AM, Peter Zijlstra wrote:
> >>> On Mon, Nov 27, 2017 at 11:49:14AM +0100, Ingo Molnar wrote:
> >>>> @@ -338,24 +366,23 @@ static inline void __native_flush_tlb_single(unsigned long addr)
> >>>>  
> >>>>  static inline void __flush_tlb_all(void)
> >>>>  {
> >>>> +	if (boot_cpu_has(X86_FEATURE_PGE)) {
> >>>>  		__flush_tlb_global();
> >>>> +	} else {
> >>>>  		__flush_tlb();
> >>>> +		tlb_flush_shared_nonglobals();
> >>> I do however think this one is superfluous; if we do not have PGE we
> >>> also do not have PCID and every CR3 switch flushes everything.
> >>
> >> I tried to sprinkle these around at all the sites that did non-global
> >> kernel flushes.  In the case that it's superfluous !KAISER, it's a noop
> >> anyway.  In the (currently unsupported) case that we *do* need it, well,
> >> we need it.
> > 
> > I'm confused. When would we need it there?
> 
> __flush_tlb() does a flushing CR3 write that flushes the current PCID.
> If we need other PCIDs flushed, we have to do it via the
> tlb_flush_shared_nonglobals() mechanism.

But the thing is, you _cannot_ have PCID enabled in that branch.

> Does it matter today in practice?  Nope, we never have that situation.
> But, it also doesn't _hurt_ to have that line there in any way.

Well, it confused the heck out of me.